- Nov 27, 2013
-
-
Björn Stenberg authored
This fixes a rare Happy Eyeballs bug where if the first IP family runs out of addresses before the second-family-timer fires, and the second IP family's first connect fails immediately, no further IPs of the second family are attempted.
-
- Nov 24, 2013
-
-
Daniel Stenberg authored
When adding entries to the DNS cache with CURLOPT_RESOLVE, they are marked 'inuse' forever to prevent them from ever being removed in normal operations. Still, the code that pruned out-of-date DNS entries didn't care for the 'inuse' struct field and pruned it anyway! Reported-by: Romulo A. Ceccon Bug: http://curl.haxx.se/bug/view.cgi?id=1303
-
- Nov 23, 2013
-
-
Steve Holme authored
Removed unnecessary SMTP_STOP state changes on failure. Removed hard return on failure in smtp_state_data_resp().
-
- Nov 21, 2013
-
-
Christian Grothoff authored
Added new API for returning a SSL backend type and pointer, in order to allow access to the TLS internals, that may then be used to obtain X509 certificate information for example.
-
- Nov 17, 2013
-
-
Steve Holme authored
Commands such as NOOP, RSET and HELP would be sent with a space at the end of the command, for example: "NOOP ".
-
Steve Holme authored
Otherwise a NOOP operation would be performed which a) only returns a single line response and not a multiline response where -I needs to be used, and b) provides an inconsistent user experience compared to that of the POP3 and IMAP protocols.
-
Steve Holme authored
The buffer allocated by smtp_parse_custom_request() was not freed.
-
Steve Holme authored
singleipconnect() could return the file descriptor of an open socket even though the function returned a CURLE_COULDNT_CONNECT error code from commit ed1662c3 and 02fbc26d. This could cause tests 19, 704 and 1233 to fail on FreeBSD, AIX and Solaris.
-
- Nov 15, 2013
-
-
Steve Holme authored
-
Daniel Stenberg authored
-
Steve Holme authored
-
Steve Holme authored
-
Steve Holme authored
-
Steve Holme authored
-
Steve Holme authored
Incorrectly processed multiline server greeting responses as "wanted" continue responses in smtp_endofresp(), from commit f16c0de4, which in turn broke the SMTP server detection in the test suite, because the EHLO command would not be sent.
-
Steve Holme authored
warning: unused variable 'smtpc'
-
Steve Holme authored
Added a loop to smtp_statemach_act() in which Curl_pp_readresp() is called until the cache is drained. Without this multiple responses received in a single packet could result in a hang or delay.
-
Steve Holme authored
Similar to the processing of untagged CAPABILITY responses in IMAP moved the processing of multiline EHLO responses to smtp_state_ehlo_resp() and introduced an internal response code of one to differentiate a multiline continuation from the end of command. This also allows for the separate processing of multiline responses from commands such as VRFY and EXPN.
-
- Nov 14, 2013
-
-
Steve Holme authored
-
Björn Stenberg authored
singleipconnect() did not return the open socket descriptor on some errors, thereby sometimes causing a socket leak. This patch ensures the socket is always returned.
-
- Nov 13, 2013
-
-
Nick Zitzmann authored
Even though this is only a formality (since not many people build on Mavericks while targeting Leopard), since we still support Leopard at the earliest, we might as well be pedantic.
-
Nick Zitzmann authored
It turns out that some of the constants necessary to make this feature work are missing from Snow Leopard's Security framework even though they are defined in the headers. Bug: http://curl.haxx.se/mail/lib-2013-11/0076.html Reported by: myriachan
-
- Nov 12, 2013
-
-
Steve Holme authored
Rather than set the authentication options as part of the login details specified in the URL, or via the older CURLOPT_USERPWD option, added a new libcurl option to allow the login options to be set separately.
-
Steve Holme authored
-
- Nov 11, 2013
-
-
Björn Stenberg authored
This patch fixes and issue introduced in commit 7d7df831, if the tunnel state was TUNNEL_CONNECT, waitconnect_getsock() would return a bitmask indicating a readable socket but never stored the socket in the return array.
-
- Nov 10, 2013
-
-
Björn Stenberg authored
The temporary sockets used for Happy Eyeballs were not closed properly, if curl exited prematurely, which this patch fixes.
-
Kim Vandry authored
-
- Nov 05, 2013
-
-
Steve Holme authored
-
Björn Stenberg authored
The reason for this loop's existence was removed in commit 02fbc26d.
-
Daniel Stenberg authored
Our own printf() replacement clearly can't properly handle %.*s with a string that isn't zero terminated. Instead of fixing the printf code or even figuring out what the proper posix behavior is, I reverted this piece of the code back to the previous version where it does malloc + memcpy instead. Regression added in e839446c, released in curl 7.32.0. Reported-by: Felix Yan Bug: http://curl.haxx.se/bug/view.cgi?id=1295
-
Steve Holme authored
-
- Nov 04, 2013
-
-
Björn Stenberg authored
This patch adds a 200ms delay between the first and second address family socket connection attempts. It also iterates over IP addresses in the order returned by the system, meaning most dual-stack systems will try IPv6 first. Additionally, it refactors the connect code, removing most code that handled synchronous connects. Since all sockets are now non-blocking, the logic can be made simpler.
-
Steve Holme authored
-
Steve Holme authored
nss.c:702: warning: pointer targets in passing argument 3 of 'Curl_extract_certinfo' differ in signedness nss.c:702: warning: pointer targets in passing argument 4 of 'Curl_extract_certinfo' differ in signedness Made sure the cast was correctly "unsigned char *" to "char *" and not "unsigned char *" to "unsigned char *".
-
Steve Holme authored
nss.c:700: warning: pointer targets in passing argument 3 of 'Curl_extract_certinfo' differ in signedness nss.c:700: warning: pointer targets in passing argument 4 of 'Curl_extract_certinfo' differ in signedness
-
- Nov 03, 2013
-
-
Steve Holme authored
No need for a rhs condition on a bitwise compare.
-
Steve Holme authored
warning: implicit declaration of function 'Curl_extract_certinfo'
-
Steve Holme authored
warning: declaration of 'chsize' shadows a global declaration
-
Steve Holme authored
curl_sasl.c:294: warning: dereferencing type-punned pointer will break strict-aliasing rules getpart.c:201: warning: dereferencing type-punned pointer will break strict-aliasing rules
-
Steve Holme authored
Introduced in commit 7d7df831 curl would loop displaying "Whut?" if it was trying to connect to an address and port that didn't have anything listening on it.
-