1. 27 May, 2013 1 commit
  2. 22 May, 2013 2 commits
    • Mike Giancola's avatar
      ossl_recv: SSL_read() returning 0 is an error too · 520833cb
      Mike Giancola authored
      SSL_read can return 0 for "not successful", according to the open SSL
      documentation: http://www.openssl.org/docs/ssl/SSL_read.html
      520833cb
    • Mike Giancola's avatar
      ossl_send: SSL_write() returning 0 is an error too · e58d9c87
      Mike Giancola authored
      We found that in specific cases if the connection is abruptly closed,
      the underlying socket is listed in a close_wait state. We continue to
      call the curl_multi_perform, curl_mutli_fdset etc. None of these APIs
      report the socket closed / connection finished.  Since we have cases
      where the multi connection is only used once, this can pose a problem
      for us. I've read that if another connection was to come in, curl would
      see the socket as bad and attempt to close it at that time -
      unfortunately, this does not work for us.
      
      I found that in specific situations, if SSL_write returns 0, curl did
      not recognize the socket as closed (or errored out) and did not report
      it to the application. I believe we need to change the code slightly, to
      check if ssl_write returns 0. If so, treat it as an error - the same as
      a negative return code.
      
      For OpenSSL - the ssl_write documentation is here:
      http://www.openssl.org/docs/ssl/SSL_write.html
      e58d9c87
  3. 21 May, 2013 2 commits
  4. 20 May, 2013 1 commit
  5. 19 May, 2013 3 commits
  6. 18 May, 2013 1 commit
  7. 16 May, 2013 1 commit
  8. 12 May, 2013 2 commits
  9. 11 May, 2013 1 commit
  10. 09 May, 2013 2 commits
  11. 08 May, 2013 1 commit
  12. 07 May, 2013 3 commits
  13. 06 May, 2013 9 commits
  14. 05 May, 2013 1 commit
  15. 04 May, 2013 5 commits
  16. 03 May, 2013 3 commits
  17. 02 May, 2013 2 commits