- Feb 14, 2013
-
-
Daniel Stenberg authored
Clarify the code by reducing ifdefs
-
Daniel Stenberg authored
This function was only used twice, both in places where performance isn't crucial (socks + if2ip). Removing the use of this function removes the need to have our private version for systems without it == reduced amount of code. Also, in the SOCKS case it is clearly better to fail gracefully rather than to truncate the results. This work was triggered by a bug report on the strcal prototype in strequal.h. strlcat was added in commit db70cd28 in February 2001! Bug: http://curl.haxx.se/bug/view.cgi?id=1192 Reported by: Jeremy Huddleston
-
Daniel Stenberg authored
As Curl_FormBoundary() is no longer used outside of this file (since commit ad7291c1), it is now renamed to formboundary() and is made static.
-
- Feb 13, 2013
-
-
Daniel Stenberg authored
Instead of just abusing the pseudo-randomizer from Curl_FormBoundary(), this now uses Curl_ossl_random() to get entropy.
-
Steve Holme authored
Replaced two explicit comparisons of CURLE_OK with boolean alternatives. General tidy up of comments.
-
Steve Holme authored
The smtp_connect() function was setting the member variables of the pingpong structure twice, once before calling Curl_pp_init() and once after!
-
Yang Tse authored
Use 'vs' directory tree given that 'vc' intended one clashes with an already existing build target in file Makefile.dist.
-
Daniel Stenberg authored
Version 7.29.0 uses Makefiles generated with a newer version of the autotools than the previous 7.28.1. These Makefiles try to install e.g. header files by calling install-sh with multiple source files as arguments. The bundled install-sh is to old and does not support this. The problem only occurs, if install-sh is actually being used, ie. the platform install executable is to old or not usable. Example: Solaris 10. The files install-sh and mkinstalldirs are now updated with the automake 1.11.3 versions. A better fix might be to completely remove them from git and force the files to be added/created during buildconf. Bug: http://curl.haxx.se/bug/view.cgi?id=1195 Reported by: Rainer Jung
-
Yang Tse authored
-
Yang Tse authored
-
- Feb 12, 2013
-
-
Steve Holme authored
Fixed a small whitespace issue that crept in there in commit 508cdf4d.
-
Steve Holme authored
-
Steve Holme authored
Fixed a null pointer reference when an empty challenge is passed to the Curl_sasl_create_digest_md5_message() function. Bug: http://sourceforge.net/p/curl/bugs/1193/ Reported by: Saran Neti
-
Steve Holme authored
Removed unnecessary end of line check and return.
-
Nick Zitzmann authored
An ambiguity in the SSLWrite() documentation lead to a bad inference in the code where we assumed SSLWrite() returned the amount of bytes written to the socket, when that is not actually true; it returns the amount of data that is buffered for writing to the socket if it returns errSSLWouldBlock. Now darwinssl_send() returns CURLE_AGAIN if data is buffered but not written. Reference URL: http://curl.haxx.se/mail/lib-2013-02/0145.html
-
Steve Holme authored
-
Steve Holme authored
Reworked the pp->endofresp() function so that the conndata, line and line length are passed down to it just as with Curl_client_write() rather than each implementation of the function having to query these values. Additionally changed the int return type to bool as this is more representative of the function's usage.
-
- Feb 11, 2013
-
-
Steve Holme authored
Corrected the order of the upgrade_tls() functions and moved the handler upgrade and getsock() functions out from the middle of the state related functions.
-
Steve Holme authored
Corrected the order of the pop3_state_capa() / imap_state_capability() and the pop3_state_capa_resp() / imap_state_capability_resp() functions to match the execution order.
-
Ulion authored
Test 1212 added to verify Bug: http://curl.haxx.se/bug/view.cgi?id=1190
-
Steve Holme authored
-
- Feb 10, 2013
-
-
Steve Holme authored
-
Linus Nielsen authored
-
Steve Holme authored
Corrected the order of the CAPA / CAPABILITY state machine constants to match the execution order.
-
Steve Holme authored
-
Steve Holme authored
Added honoring of the tls_supported flag when starting a TLS upgrade rather than unconditionally attempting it. If the use_ssl flag is set to CURLUSESSL_TRY and the server doesn't support TLS upgrades then the connection will continue to authenticate. If this flag is set to CURLUSESSL_ALL then the connection will complete with a failure as it did previously.
-
Steve Holme authored
Added honoring of the tls_supported flag when starting a TLS upgrade rather than unconditionally attempting it. If the use_ssl flag is set to CURLUSESSL_TRY and the server doesn't support TLS upgrades then the connection will continue to authenticate. If this flag is set to CURLUSESSL_ALL then the connection will complete with a failure as it did previously.
-
Steve Holme authored
Added honoring of the tls_supported flag when starting a TLS upgrade rather than unconditionally attempting it. If the use_ssl flag is set to CURLUSESSL_TRY and the server doesn't support TLS upgrades then the connection will continue to authenticate. If this flag is set to CURLUSESSL_ALL then the connection will complete with a failure as it did previously.
-
Alessandro Ghedini authored
-
Steve Holme authored
Added sending of initial CAPA command before STLS is sent. This allows for the detection of the capability before trying to upgrade the connection.
-
Steve Holme authored
Added sending of initial CAPABILITY command before STARTTLS is sent. This allows for the detection of the capability before trying to upgrade the connection.
-
Steve Holme authored
Introduced detection of the STARTTLS capability, in order to add support for TLS upgrades without unconditionally sending the STARTTLS command.
-
Steve Holme authored
Introduced detection of the STLS capability, in order to add support for TLS upgrades without unconditionally sending the STLS command.
-
Steve Holme authored
Introduced detection of the STARTTLS capability, in order to add support for TLS upgrades without unconditionally sending the STARTTLS command.
-
Steve Holme authored
-
- Feb 09, 2013
-
-
Steve Holme authored
Follow up fix to commit 62bd2174 to cater for servers that don't respond with a 250 in their EHLO responses. Additionally updated the SMTP tests to respond with a 250 response code as per RFC5321.
-
Steve Holme authored
Fixed the SASL capability detection to include the space character before the authentication mechanism list. Otherwise a capability such as SASLSOMETHING would be interpreted as enabling SASL and potentially trying to identify SOMETHING as a mechanism.
-
Steve Holme authored
Corrected an incorrect return value when -ERR is received from the server - introduced in commit b5bb61ee (June 2012).
-
Steve Holme authored
Follow up fix to commit 23d17190 as EHLO capabilities can exist within a positive response line.
-
Steve Holme authored
Follow up to commit 40f9bb78 to fix missing capabilities after an AUTH line.
-