Skip to content
  1. Feb 12, 2007
  2. Feb 06, 2007
  3. Feb 05, 2007
    • Daniel Stenberg's avatar
      - Michael Wallner provided a patch that adds support for CURLOPT_TIMEOUT_MS · 91386937
      Daniel Stenberg authored
        and CURLOPT_CONNECTTIMEOUT_MS that, as their names should hint, do the
        timeouts with millisecond resolution instead. The only restriction to that
        is the alarm() (sometimes) used to abort name resolves as that uses full
        seconds. I fixed the FTP response timeout part of the patch.
      
        Internally we now count and keep the timeouts in milliseconds but it also
        means we multiply set timeouts with 1000. The effect of this is that no
        timeout can be set to more than 2^31 milliseconds (on 32 bit systems), which
        equals 24.86 days.  We probably couldn't before either since the code did
        *1000 on the timeout values on several places already.
      91386937
  4. Feb 03, 2007
  5. Jan 29, 2007
  6. Jan 28, 2007
  7. Jan 27, 2007
  8. Jan 25, 2007
  9. Jan 23, 2007
    • Daniel Stenberg's avatar
      - David McCreedy did NTLM changes mainly for non-ASCII platforms: · 354c8dcd
      Daniel Stenberg authored
        #1
        There's a compilation error in http_ntlm.c if USE_NTLM2SESSION is NOT
        defined.  I noticed this while testing various configurations.  Line 867 of
        the current http_ntlm.c is a closing bracket for an if/else pair that only
        gets compiled in if USE_NTLM2SESSION is defined.  But this closing bracket
        wasn't in an #ifdef so the code fails to compile unless USE_NTLM2SESSION was
        defined.  Lines 198 and 140 of my patch wraps that closing bracket in an
        #ifdef USE_NTLM2SESSION.
      
        #2
        I noticed several picky compiler warnings when DEBUG_ME is defined.  I've
        fixed them with casting.  By the way, DEBUG_ME was a huge help in
        understanding this code.
      
        #3
        Hopefully the last non-ASCII conversion patch for libcurl in a while.  I
        changed the "NTLMSSP" literal to hex since this signature must always be in
        ASCII.
      
        Conversion code was strategically added where necessary.  And the
        Curl_base64_encode calls were changed so the binary "blobs" http_ntlm.c
        creates are NOT translated on non-ASCII platforms.
      354c8dcd
    • Dan Fandrich's avatar
      Convert (most of) the test data files into genuine XML. A handful still · 33bea767
      Dan Fandrich authored
      are not, due mainly to the lack of support for XML character entities
      (e.g. & => & ).  This will make it easier to validate test files using
      tools like xmllint, as well as edit and view them using XML tools.
      33bea767
  10. Jan 16, 2007
  11. Jan 14, 2007
  12. Jan 13, 2007
  13. Jan 05, 2007
  14. Jan 03, 2007
  15. Jan 02, 2007
  16. Dec 29, 2006
  17. Dec 22, 2006
  18. Dec 21, 2006
    • Daniel Stenberg's avatar
      Robson Braga Araujo reported bug #1618359 · 89ab5f43
      Daniel Stenberg authored
      (http://curl.haxx.se/bug/view.cgi?id=1618359) and subsequently provided a
      patch for it: when downloading 2 zero byte files in a row, curl 7.16.0
      enters an infinite loop, while curl 7.16.1-20061218 does one additional
      unnecessary request.
      
      Fix: During the "Major overhaul introducing http pipelining support and
      shared connection cache within the multi handle." change, headerbytecount
      was moved to live in the Curl_transfer_keeper structure. But that structure
      is reset in the Transfer method, losing the information that we had about
      the header size. This patch moves it back to the connectdata struct.
      89ab5f43
  19. Dec 16, 2006
  20. Dec 11, 2006
    • Daniel Stenberg's avatar
      Alexey Simak found out that when doing FTP with the multi interface and · 88c8d72a
      Daniel Stenberg authored
      something went wrong like it got a bad response code back from the server,
      libcurl would leak memory. Added test case 538 to verify the fix.
      
      I also noted that the connection would get cached in that case, which
      doesn't make sense since it cannot be re-use when the authentication has
      failed. I fixed that issue too at the same time, and also that the path
      would be "remembered" in vain for cases where the connection was about to
      get closed.
      88c8d72a
  21. Dec 06, 2006
    • Daniel Stenberg's avatar
      Sebastien Willemijns reported bug #1603712 · 840e796a
      Daniel Stenberg authored
      (http://curl.haxx.se/bug/view.cgi?id=1603712) which is about connections
      getting cut off prematurely when --limit-rate is used. While I found no such
      problems in my tests nor in my reading of the code, I found that the
      --limit-rate code was severly flawed (since it was moved into the lib, since
      7.15.5) when used with the easy interface and it didn't work as documented so
      I reworked it somewhat and now it works for my tests.
      840e796a
  22. Dec 05, 2006
  23. Dec 01, 2006
  24. Nov 25, 2006
    • Daniel Stenberg's avatar
      Venkat Akella found out that libcurl did not like HTTP responses that simply · da58d03f
      Daniel Stenberg authored
      responded with a single status line and no headers nor body. Starting now, a
      HTTP response on a persistent connection (i.e not set to be closed after the
      response has been taken care of) must have Content-Length or chunked
      encoding set, or libcurl will simply assume that there is no body.
      
      To my horror I learned that we had no less than 57(!) test cases that did bad
      HTTP responses like this, and even the test http server (sws) responded badly
      when queried by the test system if it is the test system. So although the
      actual fix for the problem was tiny, going through all the newly failing test
      cases got really painful and boring.
      da58d03f