Skip to content
  1. May 01, 2017
  2. Apr 30, 2017
  3. Apr 29, 2017
  4. Apr 27, 2017
  5. Apr 26, 2017
  6. Apr 25, 2017
  7. Apr 24, 2017
  8. Apr 23, 2017
  9. Apr 22, 2017
    • Alan Jenkins's avatar
      multi: clarify condition in curl_multi_wait · be299a4d
      Alan Jenkins authored
      `if(nfds || extra_nfds) {` is followed by `malloc(nfds * ...)`.
      
      If `extra_fs` could be non-zero when `nfds` was zero, then we have
      `malloc(0)` which is allowed to return `NULL`. But, malloc returning
      NULL can be confusing. In this code, the next line would treat the NULL
      as an allocation failure.
      
      It turns out, if `nfds` is zero then `extra_nfds` must also be zero.
      The final value of `nfds` includes `extra_nfds`.  So the test for
      `extra_nfds` is redundant.  It can only confuse the reader.
      
      Closes #1439
      be299a4d
    • Marcel Raad's avatar
      lib: fix maybe-uninitialized warnings · 4a8cf6c4
      Marcel Raad authored
      With -Og, GCC complains:
      
      easy.c:628:7: error: ‘mcode’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
      
      ../lib/strcase.h:35:29: error: ‘tok_buf’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
      vauth/digest.c:208:9: note: ‘tok_buf’ was declared here
      
      ../lib/strcase.h:35:29: error: ‘tok_buf’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
      vauth/digest.c:566:15: note: ‘tok_buf’ was declared here
      
      Fix this by initializing the variables.
      4a8cf6c4
    • Dan Fandrich's avatar
      gnutls: removed some code when --disable-verbose is configured · f761da76
      Dan Fandrich authored
      This reduces the binary size and fixes a compile warning.
      f761da76
    • Daniel Stenberg's avatar
      llist: no longer uses malloc · cbae73e1
      Daniel Stenberg authored
      The 'list element' struct now has to be within the data that is being
      added to the list. Removes 16.6% (tiny) mallocs from a simple HTTP
      transfer. (96 => 80)
      
      Also removed return codes since the llist functions can't fail now.
      
      Test 1300 updated accordingly.
      
      Closes #1435
      cbae73e1
  10. Apr 21, 2017
    • Marcel Raad's avatar
      typecheck-gcc: handle function pointers properly · cbb59ed9
      Marcel Raad authored
      All the callbacks passed to curl_easy_setopt are defined as function
      pointers. The possibility to pass both functions and function pointers
      was handled for the callbacks that typecheck-gcc.h defined as
      compatible, but not for the public callback types themselves.
      
      This makes all compatible callback types defined in typecheck-gcc.h
      function pointers too and checks all functions uniformly with
      _curl_callback_compatible, which handles both functions and function
      pointers.
      
      A symptom of the problem was a warning in tool_operate.c with
      --disable-libcurl-option and without --enable-debug as that file
      passes the callback functions to curl_easy_setopt directly.
      
      Fixes https://github.com/curl/curl/issues/1403
      Closes https://github.com/curl/curl/pull/1404
      cbb59ed9