1. 30 Nov, 2014 3 commits
    • Steve Holme's avatar
      transfer: Code style policing · 56120ca0
      Steve Holme authored
      Prefer ! rather than NULL in if statements, added comments and updated
      function spacing, argument spacing and line spacing to be more readble.
      56120ca0
    • Steve Holme's avatar
      transfer: Fixed existing scratch buffer being checked for NULL twice · 785d76d6
      Steve Holme authored
      If the scratch buffer already existed when the CRLF conversion was
      performed then the buffer pointer would be checked twice for NULL. This
      second check is only necessary if the call to malloc() was performed by
      the first check.
      785d76d6
    • Steve Holme's avatar
      smtp: Fixed dot stuffing being performed when no new data read · 9afd9702
      Steve Holme authored
      Whilst I had moved the dot stuffing code from being performed before
      CRLF conversion takes place to after it, in commit 4bd860a0, I had
      moved it outside the 'when something read' block of code when meant
      it could perform the dot stuffing twice on partial send if nread
      happened to contain the right values. It also meant the function could
      potentially read past the end of buffer. This was highlighted by the
      following warning:
      
      warning: `nread' might be used uninitialized in this function
      9afd9702
  2. 29 Nov, 2014 7 commits
  3. 28 Nov, 2014 2 commits
  4. 27 Nov, 2014 2 commits
  5. 26 Nov, 2014 4 commits
  6. 25 Nov, 2014 9 commits
  7. 24 Nov, 2014 2 commits
  8. 23 Nov, 2014 8 commits
  9. 22 Nov, 2014 3 commits