Commit 409265a5 authored by Steve Holme's avatar Steve Holme
Browse files

ntlm: Fixed static'ness of local decode function

parent 885119bf

lib/curl_ntlm_msgs.c

+6 −6
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ static unsigned int readshort_le(unsigned char *buf) 
}



/*

 * Curl_ntlm_decode_type2_target()

 * ntlm_decode_type2_target()

 *

 * This is used to decode the "target info" in the ntlm type-2 message

 * received.
@@ -180,7 +180,7 @@ static unsigned int readshort_le(unsigned char *buf) 
 *

 * Returns CURLE_OK on success.

 */

CURLcode Curl_ntlm_decode_type2_target(struct SessionHandle *data,

static CURLcode ntlm_decode_type2_target(struct SessionHandle *data,

                                         unsigned char *buffer,

                                         size_t size,

                                         struct ntlmdata *ntlm)
@@ -303,7 +303,7 @@ CURLcode Curl_ntlm_decode_type2_message(struct SessionHandle *data, 
  memcpy(ntlm->nonce, &type2[24], 8);



  if(ntlm->flags & NTLMFLAG_NEGOTIATE_TARGET_INFO) {

    result = Curl_ntlm_decode_type2_target(data, type2, type2_len, ntlm);

    result = ntlm_decode_type2_target(data, type2, type2_len, ntlm);

    if(result) {

      free(type2);

      infof(data, "NTLM handshake failure (bad type-2 message)\n");

lib/curl_ntlm_msgs.h

+0 −6
Original line number Diff line number Diff line
@@ -46,12 +46,6 @@ CURLcode Curl_ntlm_decode_type2_message(struct SessionHandle *data, 
                                        const char* header,

                                        struct ntlmdata* ntlm);



/* This is to decode target info received in NTLM type-2 message */

CURLcode Curl_ntlm_decode_type2_target(struct SessionHandle *data,

                                       unsigned char* buffer,

                                       size_t size,

                                       struct ntlmdata* ntlm);



/* NTLM buffer fixed size, large enough for long user + host + domain */

#define NTLM_BUFSIZE 1024