- Sep 13, 2014
-
-
Marcel Raad authored
Bug: http://curl.haxx.se/bug/view.cgi?id=1422 Verified-by: Steve Holme
-
- Sep 12, 2014
-
-
Ulrich Telle authored
Removed ISC_REQ_* flags from calls to InitializeSecurityContext to fix bug in NTLM handshake for HTTP proxy authentication. NTLM handshake for HTTP proxy authentication failed with error SEC_E_INVALID_TOKEN from InitializeSecurityContext for certain proxy servers on generating the NTLM Type-3 message. The flag ISC_REQ_CONFIDENTIALITY seems to cause the problem according to the observations and suggestions made in a bug report for the QT project (https://bugreports.qt-project.org/browse/QTBUG-17322). Removing all the flags solved the problem. Bug: http://curl.haxx.se/mail/lib-2014-08/0273.html Reported-by: Ulrich Telle Assisted-by: Steve Holme, Daniel Stenberg
-
- Sep 11, 2014
-
-
Viktor Szakats authored
-
- Sep 10, 2014
-
-
Paul Howarth authored
Bug: http://curl.haxx.se/mail/lib-2014-09/0064.html
-
Daniel Stenberg authored
As a sort of step forward, this script will now first try to get the data from the HTTPS URL using curl, and only if that fails it will switch back to the HTTP transfer using perl's native LWP functionality. To reduce the risk of this script being tricked. Using HTTPS to get a cert bundle introduces a chicken-and-egg problem so we can't really ever completely disable HTTP, but chances are that most users already have a ca cert bundle that trusts the mozilla.org site that this script downloads from. A future version of this script will probably switch to require a dedicated "insecure" command line option to allow downloading over HTTP (or unverified HTTPS).
-
Daniel Stenberg authored
Test 61 was modified to verify this. CVE-2014-3620 Reported-by: Tim Ruehsen URL: http://curl.haxx.se/docs/adv_20140910B.html
-
Tim Rühsen authored
By not detecting and rejecting domain names for partial literal IP addresses properly when parsing received HTTP cookies, libcurl can be fooled to both send cookies to wrong sites and to allow arbitrary sites to set cookies for others. CVE-2014-3613 Bug: http://curl.haxx.se/docs/adv_20140910A.html
-
- Sep 08, 2014
-
-
Daniel Stenberg authored
-
Catalin Patulea authored
Signed-off-by:
Catalin Patulea <cat@vv.carleton.ca>
-
- Sep 07, 2014
-
-
Brandon Casey authored
Historically the default "unknown" value for progress.size_dl and progress.size_ul has been zero, since these values are initialized implicitly by the calloc that allocates the curl handle that these variables are a part of. Users of curl that install progress callbacks may expect these values to always be >= 0. Currently it is possible for progress.size_dl and progress.size_ul to by set to a value of -1, if Curl_pgrsSetDownloadSize() or Curl_pgrsSetUploadSize() are passed a "size" of -1 (which a few places currently do, and a following patch will add more). So lets update Curl_pgrsSetDownloadSize() and Curl_pgrsSetUploadSize() so they make sure that these variables always contain a value that is >= 0. Updates test579 and test599. Signed-off-by:
Brandon Casey <drafnel@gmail.com>
-
Steve Holme authored
As the current element in the list is free()d by Curl_llist_remove(), when the associated connection is pending, reworked the loop to avoid accessing the next element through e->next afterward.
-
- Sep 06, 2014
-
-
Steve Holme authored
warning: implicit conversion from enumeration type 'CURLMcode' to different enumeration type 'CURLcode'
-
Steve Holme authored
Small follow up to commit 898808fa to use auth constants rather than hard code value when clearing picked authentication mechanism.
-
- Sep 05, 2014
-
-
Vilmos Nebehaj authored
SecCertificateCopyPublicKey() is not available on iPhone. Use CopyCertSubject() instead to see if the certificate returned by SecCertificateCreateWithData() is valid. Reported-by: Toby Peterson
-
- Sep 02, 2014
-
-
Daniel Stenberg authored
... as the struct is free()d in the end anyway. It was first pointed out to me that one of the ->msglist assignments were supposed to have been ->pending but was a copy and paste mistake when I realized none of the clearing of pointers had to be there.
-
Daniel Stenberg authored
... instead of scanning through all handles, stash only the actual handles that are in that state in the new ->pending list and scan that list only. It should be mostly empty or very short. And only used for pipelining. This avoids a rather hefty slow-down especially notable if you add many handles to the same multi handle. Regression introduced in commit 0f147887 (version 7.30.0). Bug: http://curl.haxx.se/mail/lib-2014-07/0206.html Reported-by: David Meyer
-
- Sep 01, 2014
-
-
Andre Heinecke authored
Forwards the setting as minimum ssl version (if set) to polarssl. If the server does not support the requested version the SSL Handshake will fail. Bug: http://curl.haxx.se/bug/view.cgi?id=1419
-
- Aug 31, 2014
-
-
Vilmos Nebehaj authored
SecCertificateCreateWithData() returns a non-NULL SecCertificateRef even if the buffer holds an invalid or corrupt certificate. Call SecCertificateCopyPublicKey() to make sure cacert is a valid certificate.
-
Daniel Stenberg authored
Introducing Curl_expire_latest(). To be used when we the code flow only wants to get called at a later time that is "no later than X" so that something can be checked (and another timeout be added). The low-speed logic for example could easily be made to set very many expire timeouts if it would be called faster or sooner than what it had set its own timer and this goes for a few other timers too that aren't explictiy checked for timer expiration in the code. If there's no condition the code that says if(time-passed >= TIME), then Curl_expire_latest() is preferred to Curl_expire(). If there exists such a condition, it is on the other hand important that Curl_expire() is used and not the other. Bug: http://curl.haxx.se/mail/lib-2014-06/0235.html Reported-by: Florian Weimer
-
Michael Wallner authored
While waiting for a host resolve, check if the host cache may have gotten the name already (by someone else), for when the same name is resolved by several simultanoues requests. The resolver thread occasionally gets stuck in getaddrinfo() when the DNS or anything else is crappy or slow, so when a host is found in the DNS cache, leave the thread alone and let itself cleanup the mess.
-
- Aug 30, 2014
-
-
Vilmos Nebehaj authored
If the --cacert option is used with a CA certificate bundle that contains multiple CA certificates, iterate through it, adding each certificate as a trusted root CA.
-
- Aug 26, 2014
-
-
Tatsuhiro Tsujikawa authored
-
- Aug 25, 2014
-
-
Daniel Stenberg authored
This is usually due to failed auth. There's no point in us keeping such a connection alive since it shouldn't be re-used anyway. Bug: http://curl.haxx.se/bug/view.cgi?id=1381 Reported-by: Marcel Raad
-
Jakub Zakrzewski authored
At this point I can build libcurl on windows. It provides at least the same list of protocols as for linux build and works with our software.
-
Jakub Zakrzewski authored
-
Jakub Zakrzewski authored
It's by convention, for compatibility and because the comments say so. Just mabe someone have written a test like "#if HAVE_XX==1"
-
Daniel Stenberg authored
This was done to make sure NTLM state that is bound to a connection doesn't survive and gets used for the subsequent request - but disconnects can also be done to for example make room in the connection cache and thus that connection is not strictly related to the easy handle's current operation. The http authentication state is still kept in the easy handle since all http auth _except_ NTLM is connection independent and thus survive over multiple connections. Bug: http://curl.haxx.se/mail/lib-2014-08/0148.html Reported-by: Paras S
-
- Aug 22, 2014
-
-
Dan Fandrich authored
-
Frank Meier authored
Problem: if CURLOPT_FORBID_REUSE is set, requests using NTLM failed since NTLM requires multiple requests that re-use the same connection for the authentication to work Solution: Ignore the forbid reuse flag in case the NTLM authentication handshake is in progress, according to the NTLM state flag. Fixed known bug #77.
-
Steve Holme authored
-
- Aug 21, 2014
-
-
Steve Holme authored
warning: declaration of 'minor' shadows a global declaration
-
- Aug 20, 2014
-
-
Haris Okanovic authored
A conditionally compiled block in connect.c references WinSock 2 symbols, but used `#ifdef HAVE_WINSOCK_H` instead of `#ifdef HAVE_WINSOCK2_H`. Bug: http://curl.haxx.se/mail/lib-2014-08/0155.html
-
Daniel Stenberg authored
The URL is not a property of the connection so it should not be freed in the connection disconnect but in the Curl_close() that frees the easy handle. Bug: http://curl.haxx.se/mail/lib-2014-08/0148.html Reported-by: Paras S
-
- Aug 17, 2014
-
-
Steve Holme authored
-
Steve Holme authored
...From "mutual" to "mutual_auth" which better describes what it is.
-
Steve Holme authored
Corrected a number of the error codes that can be returned from the Curl_sasl_create_gssapi_security_message() function when things go wrong. It makes more sense to return CURLE_BAD_CONTENT_ENCODING when the inbound security challenge can't be decoded correctly or doesn't contain the KERB_WRAP_NO_ENCRYPT flag and CURLE_OUT_OF_MEMORY when EncryptMessage() fails. Unfortunately the previous error code of CURLE_RECV_ERROR was a copy and paste mistakes on my part and should have been correct in commit 4b491c67 :(
-
- Aug 16, 2014
-
-
Steve Holme authored
-
- Aug 15, 2014
-
-
Steve Holme authored
-
Steve Holme authored
-
Steve Holme authored
-