Commit f3fc3d02 authored by Steve Holme's avatar Steve Holme
Browse files

sspi: Return CURLE_LOGIN_DENIED on AcquireCredentialsHandle() failure 

Return a more appropriate error, rather than CURLE_OUT_OF_MEMORY when
acquiring the credentials handle fails. This is then consistent with
the code prior to commit f7e24683 when log-in credentials were empty.
parent f7e24683

lib/curl_ntlm_msgs.c

+1 −1
Original line number Diff line number Diff line
@@ -477,7 +477,7 @@ CURLcode Curl_ntlm_create_type1_message(const char *userp, 
                                              ntlm->p_identity, NULL, NULL,

                                              ntlm->credentials, &expiry);

  if(status != SEC_E_OK)

    return CURLE_OUT_OF_MEMORY;

    return CURLE_LOGIN_DENIED;



  /* Allocate our new context handle */

  ntlm->context = malloc(sizeof(CtxtHandle));

lib/curl_sasl_sspi.c

+2 −2
Original line number Diff line number Diff line
@@ -210,7 +210,7 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data, 
    Curl_safefree(resp);

    Curl_safefree(chlg);



    return CURLE_OUT_OF_MEMORY;

    return CURLE_LOGIN_DENIED;

  }



  /* Setup the challenge "input" security buffer */
@@ -367,7 +367,7 @@ CURLcode Curl_sasl_create_gssapi_user_message(struct SessionHandle *data, 
                                                krb5->p_identity, NULL, NULL,

                                                krb5->credentials, &expiry);

    if(status != SEC_E_OK)

      return CURLE_OUT_OF_MEMORY;

      return CURLE_LOGIN_DENIED;



    /* Allocate our new context handle */

    krb5->context = malloc(sizeof(CtxtHandle));