Commit bebf7066 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

Andrew Benham fixed a race condition in the test suite that could cause the 

test script to kill all processes in the current process group!
parent d9bd5de0

CHANGES

+4 −0
Original line number Diff line number Diff line
@@ -6,6 +6,10 @@ 


                                  Changelog



Daniel (13 January 2006)

- Andrew Benham fixed a race condition in the test suite that could cause the

  test script to kill all processes in the current process group!



Daniel (12 January 2006)

- Michael Jahn:

RELEASE-NOTES

+2 −1
Original line number Diff line number Diff line
@@ -15,6 +15,7 @@ This release includes the following changes: 


This release includes the following bugfixes:



 o test suite kill race condition

 o FTP_SKIP_PASV_IP and FTP_USE_EPSV when doing FTP over HTTP proxy

 o Doing a second request with FTP on the same bath path, would make libcurl

   confuse what current working directory it had
@@ -36,6 +37,6 @@ This release would not have looked like this without help, code, reports and 
advice from friends like these:



 Dov Murik, Jean Jacques Drouin, Andres Garcia, Yang Tse, Gisle Vanem, Dan

 Fandrich, Alexander Lazic, Michael Jahn

 Fandrich, Alexander Lazic, Michael Jahn, Andrew Benham

 

        Thanks! (and sorry if I forgot to mention someone)

tests/runtests.pl

+4 −3
Original line number Diff line number Diff line
@@ -249,9 +249,10 @@ sub startnew { 
            open(PID, "<$pidfile");

            $pid2 = 0 + <PID>;

            close(PID);

            if(kill(0, $pid2)) {

                # make sure this pid is alive, as otherwise it is just likely

                # to be the _previous_ pidfile or similar!

            if($pid2 && kill(0, $pid2)) {

                # if $pid2 is valid, then make sure this pid is alive, as

                # otherwise it is just likely to be the _previous_ pidfile or

                # similar!

                last;

            }

        }