diff --git a/CHANGES b/CHANGES index 75128e41fe33b53490bdce1d0b8332356e21cf28..0dbdbeedd14d05d70a7c1747b7a6bae323b9c291 100644 --- a/CHANGES +++ b/CHANGES @@ -6,6 +6,10 @@ Changelog +Daniel (13 January 2006) +- Andrew Benham fixed a race condition in the test suite that could cause the + test script to kill all processes in the current process group! + Daniel (12 January 2006) - Michael Jahn: diff --git a/RELEASE-NOTES b/RELEASE-NOTES index e541589896cdf583288c977526a5322204328756..d90e31210b694ee85cf1f8d40bbf8c57cd854357 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -15,6 +15,7 @@ This release includes the following changes: This release includes the following bugfixes: + o test suite kill race condition o FTP_SKIP_PASV_IP and FTP_USE_EPSV when doing FTP over HTTP proxy o Doing a second request with FTP on the same bath path, would make libcurl confuse what current working directory it had @@ -36,6 +37,6 @@ This release would not have looked like this without help, code, reports and advice from friends like these: Dov Murik, Jean Jacques Drouin, Andres Garcia, Yang Tse, Gisle Vanem, Dan - Fandrich, Alexander Lazic, Michael Jahn + Fandrich, Alexander Lazic, Michael Jahn, Andrew Benham Thanks! (and sorry if I forgot to mention someone) diff --git a/tests/runtests.pl b/tests/runtests.pl index e4a7b1071850e2c018dab0a1dab50f2174ceee9c..a982dc7122be7a0c4a551aa6d31511159af29902 100755 --- a/tests/runtests.pl +++ b/tests/runtests.pl @@ -249,9 +249,10 @@ sub startnew { open(PID, "<$pidfile"); $pid2 = 0 + <PID>; close(PID); - if(kill(0, $pid2)) { - # make sure this pid is alive, as otherwise it is just likely - # to be the _previous_ pidfile or similar! + if($pid2 && kill(0, $pid2)) { + # if $pid2 is valid, then make sure this pid is alive, as + # otherwise it is just likely to be the _previous_ pidfile or + # similar! last; } }