-
- Downloads
FTP: when EPSV gets a 229 but fails to connect, retry with PASV
This is a regression as this logic used to work. It isn't clear when it broke, but I'm assuming in 7.28.0 when we went all-multi internally. This likely never worked with the multi interface. As the failed connection is detected once the multi state has reached DO_MORE, the Curl_do_more() function was now expanded somewhat so that the ftp_do_more() function can request to go "back" to the previous state when it makes another attempt - using PASV. Added test case 1233 to verify this fix. It has the little issue that it assumes no service is listening/accepting connections on port 1... Reported-by: byte_bucket in the #curl IRC channel
Showing
- lib/ftp.c 37 additions, 28 deletionslib/ftp.c
- lib/multi.c 8 additions, 3 deletionslib/multi.c
- lib/url.c 6 additions, 4 deletionslib/url.c
- lib/url.h 2 additions, 2 deletionslib/url.h
- lib/urldata.h 1 addition, 1 deletionlib/urldata.h
- tests/data/Makefile.am 1 addition, 1 deletiontests/data/Makefile.am
- tests/data/test1233 46 additions, 0 deletionstests/data/test1233
Loading
Please register or sign in to comment