Commit 522e647c authored by Daniel Gustafsson's avatar Daniel Gustafsson
Browse files

urlapi: don't set value which is never read 



In the CURLUPART_URL case, there is no codepath which invokes url
decoding so remove the assignment of the urldecode variable. This
fixes the deadstore bug-report from clang static analysis.

Closes #3015
Reviewed-by: default avatarDaniel Stenberg <daniel@haxx.se>
parent 056cc37e

lib/urlapi.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -970,7 +970,6 @@ CURLUcode curl_url_get(CURLU *u, CURLUPart what, 
    char *scheme;

    char *scheme;

    char *options = u->options;

    char *options = u->options;

    char *port = u->port;

    char *port = u->port;

    urldecode = FALSE; /* not for the whole thing */

    if(u->scheme && strcasecompare("file", u->scheme)) {

    if(u->scheme && strcasecompare("file", u->scheme)) {

      url = aprintf("file://%s%s%s",

      url = aprintf("file://%s%s%s",

                    u->path,

                    u->path,