Unverified Commit 15ed9f87 authored by Marcel Raad's avatar Marcel Raad
Browse files

curl-compilers: enable -Wimplicit-fallthrough=4 for GCC 

This enables level 4 instead of the default level 3, which of the
currently used comments only allows /* FALLTHROUGH */ to silence the
warning.

Closes https://github.com/curl/curl/pull/2747
parent 60776a05

lib/formdata.c

+2 −1
Original line number Diff line number Diff line
@@ -302,7 +302,8 @@ CURLFORMcode FormAdd(struct curl_httppost **httppost, 
       * Set the contents property.

       */

    case CURLFORM_PTRCONTENTS:

      current_form->flags |= HTTPPOST_PTRCONTENTS; /* fall through */

      current_form->flags |= HTTPPOST_PTRCONTENTS;

      /* FALLTHROUGH */

    case CURLFORM_COPYCONTENTS:

      if(current_form->value)

        return_value = CURL_FORMADD_OPTION_TWICE;

lib/http_ntlm.c

+1 −1
Original line number Diff line number Diff line
@@ -228,7 +228,7 @@ CURLcode Curl_output_ntlm(struct connectdata *conn, bool proxy) 
    /* connection is already authenticated,

     * don't send a header in future requests */

    ntlm->state = NTLMSTATE_LAST;

    /* fall-through */

    /* FALLTHROUGH */

  case NTLMSTATE_LAST:

    Curl_safefree(*allocuserpwd);

    authp->done = TRUE;

lib/ssh.c

+2 −2
Original line number Diff line number Diff line
@@ -659,7 +659,7 @@ static CURLcode ssh_statemach_act(struct connectdata *conn, bool *block) 
      libssh2_session_set_blocking(sshc->ssh_session, 0);



      state(conn, SSH_S_STARTUP);

      /* fall-through */

      /* FALLTHROUGH */



    case SSH_S_STARTUP:

      rc = libssh2_session_startup(sshc->ssh_session, (int)sock);
@@ -675,7 +675,7 @@ static CURLcode ssh_statemach_act(struct connectdata *conn, bool *block) 


      state(conn, SSH_HOSTKEY);



      /* fall-through */

      /* FALLTHROUGH */

    case SSH_HOSTKEY:

      /*

       * Before we authenticate we should check the hostkey's fingerprint

lib/telnet.c

+1 −1
Original line number Diff line number Diff line
@@ -1606,7 +1606,7 @@ static CURLcode telnet_do(struct connectdata *conn, bool *done) 
    case 0:                     /* timeout */

      pfd[0].revents = 0;

      pfd[1].revents = 0;

      /* fall through */

      /* FALLTHROUGH */

    default:                    /* read! */

      if(pfd[0].revents & POLLIN) {

        /* read data from network */

lib/transfer.c

+2 −2
Original line number Diff line number Diff line
@@ -1519,7 +1519,7 @@ static size_t strlen_url(const char *url, bool relative) 
    switch(*ptr) {

    case '?':

      left = FALSE;

      /* fall through */

      /* FALLTHROUGH */

    default:

      if(urlchar_needs_escaping(*ptr))

        newlen += 2;
@@ -1564,7 +1564,7 @@ static void strcpy_url(char *output, const char *url, bool relative) 
    switch(*iptr) {

    case '?':

      left = FALSE;

      /* fall through */

      /* FALLTHROUGH */

    default:

      if(urlchar_needs_escaping(*iptr)) {

        snprintf(optr, 4, "%%%02x", *iptr);