Commit 022dbdb8 authored by Daniel Gustafsson's avatar Daniel Gustafsson Committed by Daniel Stenberg
Browse files

darwinssl: test for errSecSuccess in PKCS12 import rather than noErr (#993) 

While noErr and errSecSuccess are defined as the same value, the API
documentation states that SecPKCS12Import() returns errSecSuccess if
there were no errors in importing. Ensure that a future change of the
defined value doesn't break (however unlikely) and be consistent with
the API docs.
parent 8331b08d

lib/vtls/darwinssl.c

+1 −1
Original line number Diff line number Diff line
@@ -955,7 +955,7 @@ static OSStatus CopyIdentityFromPKCS12File(const char *cPath, 


    /* Here we go: */

    status = SecPKCS12Import(pkcs_data, options, &items);

    if(status == noErr && items && CFArrayGetCount(items)) {

    if(status == errSecSuccess && items && CFArrayGetCount(items)) {

      CFDictionaryRef identity_and_trust = CFArrayGetValueAtIndex(items, 0L);

      const void *temp_identity = CFDictionaryGetValue(identity_and_trust,

        kSecImportItemIdentity);