Commits · e9ee30da452953c79b3b334039fd76dd5ab5c934 · CYBER - Cyber Security / TS 103 523 MSP / TLMSP / TLMSP Apache Httpd

12 Mar, 2002 14 commits

moving SSLVerifyClient directive parsing into ssl_cmd_verify_parse · e9ee30da

Doug MacEachern authored Mar 12, 2002

function, which can also be used for SSLProxyVerify directive.

dropping support for undocumented integer form of levels (0..3)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93870 13f79535-47bb-0310-9956-ffa450edef68

e9ee30da

Added NetWare to the ifdef list · 10e208de

Bradley Nicholes authored Mar 12, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93869 13f79535-47bb-0310-9956-ffa450edef68

10e208de

fold duplication of SSL{Proxy}Protocol directives into · a1d62b1e

Doug MacEachern authored Mar 12, 2002

ssl_cmd_protocol_parse function.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93865 13f79535-47bb-0310-9956-ffa450edef68

a1d62b1e

fold some duplication of server certs/keys directive checking into · 3db2f7d8

Doug MacEachern authored Mar 12, 2002

ssl_cmd_check_aidx_max function.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93864 13f79535-47bb-0310-9956-ffa450edef68

3db2f7d8

folding some command handler duplication into two generic functions: · ea436886

Doug MacEachern authored Mar 12, 2002

ssl_cmd_check_file and ssl_cmd_check_dir.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93863 13f79535-47bb-0310-9956-ffa450edef68

ea436886

get rid of some warnings for currently unused/unprototyped functions. · 4230b447

Doug MacEachern authored Mar 12, 2002

(we can actually compile mod_ssl with -Werror if -Wstrict-prototypes
is taken out)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93862 13f79535-47bb-0310-9956-ffa450edef68

4230b447

minor performance enhancement: no need to use md5 of VHostID for the · 72681eaa

Doug MacEachern authored Mar 12, 2002

session id, just use the VHostID itself.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93861 13f79535-47bb-0310-9956-ffa450edef68

72681eaa

dropping hungarian notation · a5e885d5

Doug MacEachern authored Mar 12, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93860 13f79535-47bb-0310-9956-ffa450edef68

a5e885d5

minor style changes · 7ed6d145

Doug MacEachern authored Mar 12, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93859 13f79535-47bb-0310-9956-ffa450edef68

7ed6d145

dropping hungarian notation · 869c3b19

Doug MacEachern authored Mar 12, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93851 13f79535-47bb-0310-9956-ffa450edef68

869c3b19

various style fixups / general changes to make code more readable. · afb75e5d

Doug MacEachern authored Mar 12, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93848 13f79535-47bb-0310-9956-ffa450edef68

afb75e5d

various style fixups / general changes to make code more readable. · 2816b559

Doug MacEachern authored Mar 12, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93847 13f79535-47bb-0310-9956-ffa450edef68

2816b559

add SSL_VERIFY_PEER_STRICT shortcut for often used flags · ba36e087

Doug MacEachern authored Mar 12, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93846 13f79535-47bb-0310-9956-ffa450edef68

ba36e087

various style fixups / general changes to make code more readable. · 4540ef0a

Doug MacEachern authored Mar 12, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93845 13f79535-47bb-0310-9956-ffa450edef68

4540ef0a

10 Mar, 2002 2 commits

no need to call SSL_clear() after SSL_new() · b4e921bd

Doug MacEachern authored Mar 10, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93824 13f79535-47bb-0310-9956-ffa450edef68

b4e921bd

don't allocate SSLConnRec unless ssl is enabled on this vhost. · c6c229fd

Doug MacEachern authored Mar 10, 2002

also provides a shorter shortcut for mod_ssl hooks to decline if ssl
is not enabled.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93823 13f79535-47bb-0310-9956-ffa450edef68

c6c229fd

08 Mar, 2002 2 commits

support reuse of encrypted DSA keys on restart · 107f4274

Doug MacEachern authored Mar 08, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93799 13f79535-47bb-0310-9956-ffa450edef68

107f4274

remove unused ap_server_ctx member from SSLSrvConfigRec · b8194772

Doug MacEachern authored Mar 08, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93785 13f79535-47bb-0310-9956-ffa450edef68

b8194772

06 Mar, 2002 1 commit

apr-utils rename apr_ansi_time_to_apr_time and · 6435b17c

Ian Holsman authored Mar 06, 2002

apr_exploded_time_t.

PR:
Obtained from:
Submitted by:	Thom May <thom@planetarytramp.net>
Reviewed by:	Ian Holsman


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93733 13f79535-47bb-0310-9956-ffa450edef68

6435b17c

03 Mar, 2002 1 commit

reuse existing private key if possible for all SSLPassPhraseDialog · af2268d8

Doug MacEachern authored Mar 03, 2002

types, not just builtin.  on win32 for example, a pipe dialog might
allocate a wintty for prompting, which results in 4 prompts at
startup, 2 for each child and 2 within each when httpd "restarts
itself".
update comments on this and wrap them a bit.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93679 13f79535-47bb-0310-9956-ffa450edef68

af2268d8

01 Mar, 2002 2 commits

s/const void/const char/g in ssl_asn1_table api · 2882cebd

Doug MacEachern authored Mar 01, 2002

pointed out by gstein


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93653 13f79535-47bb-0310-9956-ffa450edef68

2882cebd

Consensus is that we should not use the scoreboard as a source of entropy. · 0856d72f

Cliff Woolley authored Mar 01, 2002

Reviewed by: OtherBill, Justin, Madhu


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93652 13f79535-47bb-0310-9956-ffa450edef68

0856d72f

28 Feb, 2002 18 commits

plug leak in newish ssl_asn1_table_set() function · d0da5b0e

Doug MacEachern authored Feb 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93648 13f79535-47bb-0310-9956-ffa450edef68

d0da5b0e

remove an XXX: we already do CRYPTO_set_locking_callback() in ssl_util_thread_setup() · 5c36f8ce
Doug MacEachern authored Feb 28, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93637 13f79535-47bb-0310-9956-ffa450edef68
```
5c36f8ce

remove #ifdef SHARED_MODULE around ssl library cleanup calls. · 1e751ebc

Doug MacEachern authored Feb 28, 2002

SHARED_MODULE is no longer defined, so we were leaking.
plus we always do a full startup/teardown regardless of being a dso or
static.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93636 13f79535-47bb-0310-9956-ffa450edef68

1e751ebc

move SSL_load_client_CA_file() comment to where we moved the call to it · c42d2544
Doug MacEachern authored Feb 28, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93635 13f79535-47bb-0310-9956-ffa450edef68
```
c42d2544

various SSLCACertificatePath fixes: · 39f2515b

Doug MacEachern authored Feb 28, 2002

- return value from apr_dir_read() was checking != APR_SUCCESS rather
  than == APR_SUCCESS, so no certs were ever loaded.

- wasn't checking return value of apr_dir_open(), now log an error and
  ssl_die() on failure.

- don't bother trying to load directories


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93634 13f79535-47bb-0310-9956-ffa450edef68

39f2515b

plug leak in ssl_init_FindCAList() where return value of · 3cc8feda

Doug MacEachern authored Feb 28, 2002

X509_NAME_oneline() used for trace logging was not freed.
now passes in a static buffer so no buffer is malloced.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93633 13f79535-47bb-0310-9956-ffa450edef68

3cc8feda

fold some duplication within ssl_init_FindCAList() into generic · 16fc2d49

Doug MacEachern authored Feb 28, 2002

ssl_init_PushCAList() function.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93632 13f79535-47bb-0310-9956-ffa450edef68

16fc2d49

need to free X509_NAME duplicates already found in the stack built by · c4a89ae6

Doug MacEachern authored Feb 28, 2002

ssl_init_FindCAList().


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93626 13f79535-47bb-0310-9956-ffa450edef68

c4a89ae6

need to free the stacks returned by calls to SSL_load_client_CA_file() · 96487ed2

Doug MacEachern authored Feb 28, 2002

in ssl_init_FindCAList(). values are pushed into another stack which
gets freed when SSL context is destroyed.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93625 13f79535-47bb-0310-9956-ffa450edef68

96487ed2

contrary to what comments say, DH* returned from ssl_dh_GetTmpParam() · 62710ab8

Doug MacEachern authored Feb 28, 2002

is _not_ static and needs to be freed via DH_free().


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93624 13f79535-47bb-0310-9956-ffa450edef68

62710ab8

need to free sc->pRevocationStore at shutdown · d7e3f22d

Doug MacEachern authored Feb 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93623 13f79535-47bb-0310-9956-ffa450edef68

d7e3f22d

always reusing existing private key for given vhost on restarts if key · 0fd7b333

Doug MacEachern authored Feb 28, 2002

is encrypted and mtime stamp has not changed. this prevents getting
prompted twice for passphrase on windows and elsewhere when server is
started with -DNO_DETACH.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93620 13f79535-47bb-0310-9956-ffa450edef68

0fd7b333

s/asn1->mtime/asn1->source_mtime/ · c94d9bb9

Doug MacEachern authored Feb 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93619 13f79535-47bb-0310-9956-ffa450edef68

c94d9bb9

initialize ssl_asn1_t.mtime to 0 · 076295a0

Doug MacEachern authored Feb 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93617 13f79535-47bb-0310-9956-ffa450edef68

076295a0

reuse vhost keys for asn1 tables where keys are allocated out · 98051986

Doug MacEachern authored Feb 28, 2002

of s->process->pool to prevent "leaking" each time we format
a vhost key.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93616 13f79535-47bb-0310-9956-ffa450edef68

98051986

switch SSLModConfigRec.tPublicCert to ssl_asn1_table api to prevent · 5681beab

Doug MacEachern authored Feb 28, 2002

leakage on restarts.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93615 13f79535-47bb-0310-9956-ffa450edef68

5681beab

switch SSLModConfigRec.tPrivateKey to ssl_asn1_table api to prevent · 07889000

Doug MacEachern authored Feb 28, 2002

leakage on restarts.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93614 13f79535-47bb-0310-9956-ffa450edef68

07889000

add ssl_asn1_table_get() wrapper and change ssl_init_TmpKeysHandle() · 7996ee92

Doug MacEachern authored Feb 28, 2002

to use it.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93613 13f79535-47bb-0310-9956-ffa450edef68

7996ee92