Commit 62710ab8 authored by Doug MacEachern's avatar Doug MacEachern
Browse files

contrary to what comments say, DH* returned from ssl_dh_GetTmpParam() 

is _not_ static and needs to be freed via DH_free().


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93624 13f79535-47bb-0310-9956-ffa450edef68
parent d7e3f22d

ssl_engine_init.c

+2 −2
Changes for ssl_engine_init.c: 2 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -318,7 +318,7 @@ void ssl_init_TmpKeysHandle(int action, server_rec *s, apr_pool_t *p) 
        length = i2d_DHparams(dh, NULL);

        ucp = ssl_asn1_table_set(mc->tTmpKeys, "DH:512", length);

        (void)i2d_DHparams(dh, &ucp); /* 2nd arg increments */

        /* no need to free dh, it's static */

        DH_free(dh);



        /* import 1024 bit DH param */

        if ((dh = ssl_dh_GetTmpParam(1024)) == NULL) {
@@ -329,7 +329,7 @@ void ssl_init_TmpKeysHandle(int action, server_rec *s, apr_pool_t *p) 
        length = i2d_DHparams(dh, NULL);

        ucp = ssl_asn1_table_set(mc->tTmpKeys, "DH:1024", length);

        (void)i2d_DHparams(dh, &ucp); /* 2nd arg increments */

        /* no need to free dh, it's static */

        DH_free(dh);

    }



    /* Allocate Keys and Params */