Skip to content
GitLab
  1. 14 Dec, 2017 1 commit
  3. 13 Dec, 2017 3 commits
  5. 12 Dec, 2017 2 commits
  7. 11 Dec, 2017 1 commit
  9. 05 Dec, 2017 2 commits
  11. 03 Dec, 2017 1 commit
  13. 02 Dec, 2017 5 commits
  15. 29 Nov, 2017 5 commits
  17. 27 Nov, 2017 2 commits
  19. 26 Nov, 2017 4 commits
    • Luca Toscano's avatar
      docs: allow Directive and <Directive> names to co-exist in the same page. · 92e3fc3f
      Luca Toscano authored 
      This work was done in trunk to allow the new mod_md's directive
names <ManagedDomain> and ManagedDomain in the same doc page (without
triggering any validate-xml/xhtml error). Subsequently this also helped
for SSLPolicy and <SSLPolicy>. All the aforementioned Directives
have not been backported yet, but these commits are needed behorehand to
allow a smoother backport procedure.

I explicitly reverted the changes to sections.xml for this backport since
they mention the above directives, not yet available in 2.4.x and hence
probably confusing for users.

Building the documentation after these changes yield to a no-op as expected.
I also tried to copy mod_md's documentation from trunk and it renders nicely.

Merge r1805189, r1805193, r1805372, r1805376, r1805189, r1806443 from trunk:

synopsis.xsl: do not render two times the same
              directive HTML if more than one
              directive share the same name.

This has happened when mod_md.xml was introduced,
and the following directives shared the same name:
* ManagedDomain
* <ManagedDomain>

With the current code each time that a node needs
to be rendered it will emit a duplicate, ending up
in the above example with 4 sections rather than two.

Uniqueness of sections will be ensured by the HTML
elements ids, to avoid errors before committing for
example (accidental duplicates, etc..).



common|synopsis.xsl: rename directive type=sections id generation

This commits is a follow up of r1805189 and it is meant
to allow directives with the same name but different type
to coexist in the same document without triggering errors
while executing validate-xhtml.

For example: mod_md.xml recently introduced the following:

* ManagedDomain
* <ManagedDomain> (this one is type=section)

In my opinion this is a perfectly valid use case and it should
be allowed/handled correctly by the doc generation process/validation.

In order to avoid clashing the directive ids will get a suffix
called "section" if type=section will be present as param.

Quicklinks, <directive> links have been updated to the new
scheme to avoid dandling pointers in the doc.

Comments/reviews are welcome, if I left something behind
please let me know.



doc xsl/dtd: introduce idtype attribute for directivesynopsis

In r1805193 synopsis.xsl was changed to allow two directives
of different type (like <SSLPolicy> and SSLPolicy) to share
the same name but have different ids (and please validate-xml/xhtml).
The downside of this action was that all the quicklinks to
existing directive sections (like <If>, <VirtualHost>, etc..)
were changed, possibly breaking external clients already
referencing them.

This change introduces a new attribute in the directivesynopsis
DTD, namely 'idtype', that will be appended to 'name'
in the id generation by synopsis.xsl. This will rollback
link names to their previous values and will allow documentators
to fine tune directivesynopsis sections as they need
(for example we have recently introduced mod_md's
ManagedDomain/<ManagedDomain>, and modssl's SSLPolicy/<SSLPolicy>).

This approach seems more precise and less invasive to me.
Of course the name of the attribute can be changed later on
to whatever term would fit best, the main concern for me at
the moment is to restore the trunk documentation to its previous
state.



common.dtd: add idtype attribute to directive

This change completes r1805372 and also fixes
links generation for <ManageDomain> and <SSLPolicy>
in sections.xml



synopsis.xsl: do not render two times the same
              directive HTML if more than one
              directive share the same name.

This has happened when mod_md.xml was introduced,
and the following directives shared the same name:
* ManagedDomain
* <ManagedDomain>

With the current code each time that a node needs
to be rendered it will emit a duplicate, ending up
in the above example with 4 sections rather than two.

Uniqueness of sections will be ensured by the HTML
elements ids, to avoid errors before committing for
example (accidental duplicates, etc..).



synopsis.xsl: fix broken translation builds

This commit is a follow up of r1805189, in which
a new logic was added to allow to repeat a directive
name only if its type is different (like SSLPolicy
and <SSLPolicy>). The change broken french translations
since the $this variable, containing the translated
sections, was not used anymore.

The XPath code could surely be improved, but it seems
more pressing to allow our translators to get back
to their daily work without interference.

build.sh validate-* worked fine, as well as the build.sh fr
translation.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1816378 13f79535-47bb-0310-9956-ffa450edef68
      92e3fc3f
    • Luca Toscano's avatar
      Documentation rebuild - part 2 · ce22f9a8
      Luca Toscano authored 
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1816375 13f79535-47bb-0310-9956-ffa450edef68
      ce22f9a8
    • Luca Toscano's avatar
      Documentation rebuild · 1dd61cfa
      Luca Toscano authored 
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1816357 13f79535-47bb-0310-9956-ffa450edef68
      1dd61cfa
    • Luca Toscano's avatar
      Sync with trunk the override suggestions for directives in: · d8c74ccc
      Luca Toscano authored 
      mod_authn_socache.xml
mod_logio.xml
mod_ssl.xml

This caused two issues:

1) ./build.sh validate-xhtml failing due to xml validation
   failures for the string "Not applicable".
2) weird categories ('none', 'Not applicable', 'None') in
   overrides.html that don't make much sense.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1816356 13f79535-47bb-0310-9956-ffa450edef68
      d8c74ccc
  21. 25 Nov, 2017 4 commits
  23. 24 Nov, 2017 1 commit
  25. 23 Nov, 2017 2 commits
  27. 18 Nov, 2017 2 commits
  29. 16 Nov, 2017 1 commit
  31. 13 Nov, 2017 4 commits
    • Jim Jagielski's avatar
      Merge r1813643 from trunk: · 6440bc78
      Jim Jagielski authored 
      mod_macro: fix usability of globally defined macros in .htaccess files.
PR 57525.

Reverts pre_config hook from r1656669 (happens too late for EXEC_ON_READ), and
ensures ap_macros is reset on restart with a pconf cleanup.

Proposed by: Jose Kahan <jose w3.org>
Reviewed by: ylavic

Submitted by: ylavic
Reviewed by: ylavic, icing, jim


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1815101 13f79535-47bb-0310-9956-ffa450edef68
      6440bc78
    • Jim Jagielski's avatar
      Merge r1811744 from trunk: · 122dce01
      Jim Jagielski authored 
      core, mod_rewrite: introduce the 'redirect-keeps-vary' note
                   to allow proper Vary header insertion when
                   dealing with a RewriteRule in a directory
                   context.

This change is an attempt to fix a long standing problem,
brought up while working on PR 58231. Our documentation clearly
states the following:

"If a HTTP header is used in a condition this header is added
to the Vary header of the response in case the condition
evaluates to true for the request."

This is currently not true for RewriteCond/Rules working in
a directory context, since when an internal redirect happens
all the outstanding response headers get dropped.

There might be a better solution so I am looking forward to
hear more opinions and comments. My goal for a delicate change
like this one would be to affect the least amount of configurations
possible, without triggering unwanted side effects.

If the solution is good for everybody tests will be written
in the suite asap.


Submitted by: elukey
Reviewed by: elukey, icing, ylavic


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1815100 13f79535-47bb-0310-9956-ffa450edef68
      122dce01
    • Jim Jagielski's avatar
      promote · bf51c4d4
      Jim Jagielski authored 
      
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1815099 13f79535-47bb-0310-9956-ffa450edef68
      bf51c4d4
    • Jim Jagielski's avatar
      tested and voted · e83af872
      Jim Jagielski authored 
      
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1815098 13f79535-47bb-0310-9956-ffa450edef68
      e83af872