Loading STATUS +1 −11 Original line number Diff line number Diff line Loading @@ -164,18 +164,8 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: http://svn.apache.org/r1790457 (Update directive name in err message) http://svn.apache.org/r1806985 2.4 convenience patch (includes CHANGES): http://home.apache.org/~jim/patches/RemoteIPProxyProtocol.2.4.x.patch http://svn.apache.org/r1806985 http://home.apache.org/~jim/patches/RemoteIPProxyProtocol.2.4-v2.patch +1: druggeri, jim mrumph: I had a chance to review this proposal. I committed some suggested changes to trunk in r1806985. Also, the copyright in mod_remoteip.c is of some concern. Perhaps the terms of the copyright should be included in that note. And on a personal note, today is my last day with Oracle. So it may well be my last day with Apache as well. It has been great working with all of you. jim: Not sure what the copyright concern is, but added r1806985 to the proposal. ylavic: RemoteIPProxyProtocol* are documented as scoped to server config and virtual host, though using ap_server_conf makes them global only (thus less useful too...). Loading Loading
STATUS +1 −11 Original line number Diff line number Diff line Loading @@ -164,18 +164,8 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: http://svn.apache.org/r1790457 (Update directive name in err message) http://svn.apache.org/r1806985 2.4 convenience patch (includes CHANGES): http://home.apache.org/~jim/patches/RemoteIPProxyProtocol.2.4.x.patch http://svn.apache.org/r1806985 http://home.apache.org/~jim/patches/RemoteIPProxyProtocol.2.4-v2.patch +1: druggeri, jim mrumph: I had a chance to review this proposal. I committed some suggested changes to trunk in r1806985. Also, the copyright in mod_remoteip.c is of some concern. Perhaps the terms of the copyright should be included in that note. And on a personal note, today is my last day with Oracle. So it may well be my last day with Apache as well. It has been great working with all of you. jim: Not sure what the copyright concern is, but added r1806985 to the proposal. ylavic: RemoteIPProxyProtocol* are documented as scoped to server config and virtual host, though using ap_server_conf makes them global only (thus less useful too...). Loading