- 10 Jun, 2015 11 commits
-
-
Matt Caswell authored
It should not be possible for DTLS message fragments to span multiple packets. However previously if the message header fitted exactly into one packet, and the fragment body was in the next packet then this would work. Obviously this would fail if packets get re-ordered mid-flight. Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
Matt Caswell authored
The underlying field returned by RECORD_LAYER_get_rrec_length() is an unsigned int. The return type of the function should match that. Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
Matt Caswell authored
In the event of an error in the HMAC function, leaks can occur because the HMAC_CTX does not get cleaned up. Thanks to the BoringSSL project for reporting this issue. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
The function EC_POINT_is_on_curve does not return a boolean value. It returns 1 if the point is on the curve, 0 if it is not, and -1 on error. Many usages within OpenSSL were incorrectly using this function and therefore not correctly handling error conditions. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by:
Kurt Roeckx <kurt@openssl.org>
-
Matt Caswell authored
The return type of BIO_number_read() and BIO_number_written() as well as the corresponding num_read and num_write members in the BIO structure has been changed from unsigned long to uint64_t. On platforms where an unsigned long is 32 bits (e.g. Windows) these counters could overflow if >4Gb is transferred. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
This adds additional checks to the processing of extensions in a ClientHello to ensure that either no extensions are present, or if they are then they take up the exact amount of space expected. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by:
Stephen Henson <steve@openssl.org>
-
Matt Caswell authored
This fixes a memory leak that can occur whilst duplicating a BIO chain if the call to CRYPTO_dup_ex_data() fails. It also fixes a second memory leak where if a failure occurs after successfully creating the first BIO in the chain, then the beginning of the new chain was not freed. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by:
Stephen Henson <steve@openssl.org>
-
Matt Caswell authored
BUF_MEM_free() attempts to cleanse memory using memset immediately prior to a free. This is at risk of being optimised away by the compiler, so replace with a call to OPENSSL_clear_free() instead. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by:
Stephen Henson <steve@openssl.org>
-
Richard Levitte authored
test/gost2814789test.c needs to include openssl/e_os2.h or it wouldn't see the defined OPENSSL_NO_* macros. Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
Richard Levitte authored
For librypto to be complete, the stuff in both crypto/ and engines/ have to be built. Doing 'make test' or 'make apps' from a clean source tree failed to do so. Corrected by using the new 'build_libcrypto' in the top Makefile. Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
Richard Levitte authored
There's a need for a target that will build all of libcrypto, so let's add 'build_libcrypto' that does this. For ortogonality, let's also add 'build_libssl'. Have both also depend on 'libcrypto.pc' and 'libssl.pc' so those get built together with the libraries. This makes 'all' depend on fewer things directly. Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
- 09 Jun, 2015 4 commits
-
-
Rich Salz authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Rich Salz authored
Except for VMS startup code. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Rich Salz authored
Also removed a source file that isn't built, and moved another one to test for eventual fixing. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Jeffrey Walton authored
Signed-off-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org>
-
- 08 Jun, 2015 5 commits
-
-
Kurt Roeckx authored
Reviewed-by:
Matt Caswell <matt@openssl.org> MR #588
-
Kurt Roeckx authored
Reviewed-by:
Matt Caswell <matt@openssl.org> MR #588
-
Dr. Stephen Henson authored
Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
Emilia Kasper authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Emilia Kasper authored
Pointed out by Victor Vasiliev (vasilvv@mit.edu) via Adam Langley (Google). Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 07 Jun, 2015 1 commit
-
-
Rodger Combs authored
Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
- 06 Jun, 2015 2 commits
-
-
Dr. Stephen Henson authored
Add extension and ciphersuites to trace code. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Dr. Stephen Henson authored
Check return value when calling ASN1_INTEGER_get to retrieve a certificate serial number. If an error occurs (which will be caused by the value being out of range) revert to hex dump of serial number. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 04 Jun, 2015 8 commits
-
-
Rich Salz authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Github User authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Kurt Roeckx authored
At least in the case of SSLv3 we can't send an extention. Reviewed-by:
Matt Caswell <matt@openssl.org> MR #811
-
Rich Salz authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
Remove a comment that suggested further clean up was required. DH_free() performs the necessary cleanup. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Matt Caswell authored
Ensure OPENSSL_cleanse() is called on the premaster secret value calculated for GOST. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Matt Caswell authored
A BIGNUM can have the value of -0. The function BN_bn2hex fails to account for this and can allocate a buffer one byte too short in the event of -0 being used, leading to a one byte buffer overrun. All usage within the OpenSSL library is considered safe. Any security risk is considered negligible. With thanks to Mateusz Kocielski (LogicalTrust), Marek Kroemeke and Filip Palian for discovering and reporting this issue. Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
Matt Caswell authored
The session object on the client side is initially created during construction of the ClientHello. If the client is DTLS1.2 capable then it will store 1.2 as the version for the session. However if the server is only DTLS1.0 capable then when the ServerHello comes back the client switches to using DTLS1.0 from then on. However the session version does not get updated. Therefore when the client attempts to resume that session the server throws an alert because of an incorrect protocol version. Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
- 03 Jun, 2015 2 commits
-
-
Dr. Stephen Henson authored
Make update with manual edit so EVP_PKEY_asn1_set_item uses the same ordinal as 1.0.2. Reviewed-by:
Matt Caswell <matt@openssl.org>
-
Sergey Agievich authored
PR#3872 Reviewed-by:
Matt Caswell <matt@openssl.org> Reviewed-by:
Stephen Henson <steve@openssl.org> (cherry picked from commit ad0fb7f4988c8a717fe6bcb035304385fbdaef41) Conflicts: crypto/asn1/ameth_lib.c
-
- 02 Jun, 2015 7 commits
-
-
Matt Caswell authored
Some tool chains (e.g. android) do not define IP_PMTUDISC_PROBE, and so this build breaks. Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
Annie Yousar authored
objects.pl only looked for a space to see if the name could be used as a C identifier. Improve the test to match the real C rules. Signed-off-by:
Rich Salz <rsalz@akamai.com> Reviewed-by:
Matt Caswell <matt@openssl.org>
-
Rich Salz authored
Here are the "rules" for handling flags that depend on #ifdef: - Do not ifdef the enum. Only ifdef the OPTIONS table. All ifdef'd entries appear at the end; by convention "engine" is last. This ensures that at run-time, the flag will never be recognized/allowed. The next two bullets entries are for silencing compiler warnings: - In the while/switch parsing statement, use #ifdef for the body to disable it; leave the "case OPT_xxx:" and "break" statements outside the ifdef/ifndef. See ciphers.c for example. - If there are multiple options controlled by a single guard, OPT_FOO, OPT_BAR, etc., put a an #ifdef around the set, and then do "#else" and a series of case labels and a break. See OPENSSL_NO_AES in cms.c for example. Reviewed-by:
Matt Caswell <matt@openssl.org>
-
Rich Salz authored
I also re-ordered some of #ifdef's. Reviewed-by:
Matt Caswell <matt@openssl.org>
-
Jeffrey Walton authored
Reviewed-by:
Matt Caswell <matt@openssl.org>
-
Richard Levitte authored
This is for consistency. Additionally, have its presence define OPENSSL_SYS_WINDOWS as well. Reviewed-by:
Matt Caswell <matt@openssl.org>
-
Gunnar Kudrjavets authored
Signed-off-by:
Rich Salz <rsalz@akamai.com> Reviewed-by:
Matt Caswell <matt@openssl.org>
-