- 14 Mar, 2016 10 commits
-
-
Andy Polyakov authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Andy Polyakov authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Andy Polyakov authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Andy Polyakov authored
but not if there is reference to empty variable. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
There are internal dependencies between the various cleanup functions. This re-orders things to try and get that right. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
OBJ_cleanup() doesn't always get called from EVP_cleanup() so needs to be explicitly called in de-init. Also BIO_sock_cleanup() also needs to be called. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Richard Levitte authored
With bash and zsh, the trap on the 5 second read does respond, but doesn't break out of the read. What's worse is that it takes away the 5 second timer, and therefore has the read hang indefinitely and (almost) unbreakable. Having the trap do 'exit 0' after reseting the tty params has it break out of read and continue with the configuration. Other shells do not appear to have the issue described here, but neither does the extra 'exit 0' appear to harm them. Reviewed-by:
Andy Polyakov <appro@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Andy Polyakov <appro@openssl.org>
-
Dr. Stephen Henson authored
Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Viktor Dukhovni <viktor@openssl.org>
-
- 13 Mar, 2016 3 commits
-
-
Dr. Stephen Henson authored
Document EVP_PKEY_id() and EVP_PKEY_base_id(). Reviewed-by:
Viktor Dukhovni <viktor@openssl.org>
-
Richard Levitte authored
Reviewed-by:
Kurt Roeckx <kurt@openssl.org>
-
Richard Levitte authored
A couple of '$(PERLASM_SCHEM' had sneaked in. Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
- 12 Mar, 2016 12 commits
-
-
Richard Levitte authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
The reason to do so is that some of the generators detect PIC flags like -fPIC and -KPIC, and those are normally delivered in LD_CFLAGS. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
When passing down values to Makefile.shared, do so with single quotes as much as possible to avoid having the shell create a mess of quotes. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
The variable SHARED_CFLAGS and SHARD_LDFLAGS were used in the Unix template because they normally contain options used when building "shared". The Windows template, on the other hand, uses LIB_CFLAGS, to express the intended use of those flags rather than their content. The Windows template still used SHARED_LDFLAGS, which seems inconsistent. To harmonize the two, any SHARED_CFLAGS gets renamed to LIB_CFLAGS and SHARED_LDFLAGS to LIB_LDFLAGS. That makes the intent consistent along with BIN_{C,LD}FLAGS and DSO_{C,LD}FLAGS. Finally, make sure to pass down $(LIB_CFLAGS) or $(DSO_CFLAGS) along with $(CFLAGS) when using Makefile.shared. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Emilia Kasper authored
ENGINE_cleanup calls CRYPTO_free_ex_data and therefore, CRYPTO_cleanup_all_ex_data - which cleans up the method pointers - must run after ENGINE_cleanup. Additionally, don't needlessly initialize the EX_CALLBACKS stack during e.g. CRYPTO_free_ex_data. The only time this is actually needed is when reserving the first ex data index. Specifically, since sk_num returns -1 on NULL input, the rest of the code already handles a NULL method stack correctly. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Rich Salz authored
With help from Viktor. Reviewed-by:
Viktor Dukhovni <viktor@openssl.org>
-
Emilia Kasper authored
ccache + clang produces a false strcmp warning, see https://llvm.org/bugs/show_bug.cgi?id=20144 Since this only happens with ccache and --strict-warnings, and only with certain versions of glibc / clang, disabling ccache is a reasonable short-term workaround. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Emilia Kasper authored
Reviewed-by:
Matt Caswell <matt@openssl.org>
-
Rich Salz authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Richard Levitte authored
While insignificant on Unix like systems, this is significant on systems like VMS. Reviewed-by:
Rich Salz <rsalz@openssl.org> Reviewed-by:
Tim Hudson <tjh@openssl.org>
-
Richard Levitte authored
It turns out that different sed implementations treat -i differently to cause issues. make it simpler by avoiding it entirely and give perl the trust to be consistent enough. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
That doesn't change even to make a dummy to hide its unavailability. Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
- 11 Mar, 2016 15 commits
-
-
Matt Caswell authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Matt Caswell authored
On Windows we call WSAGetLastError() to find out the last error that happened on a socket operation. We use this to find out whether we can retry the operation or not. You are supposed to call this immediately however in a couple of places we logged an error first. This can end up making other Windows system calls to get the thread local error state. Sometimes that can clobber the error code, so if you call WSAGetLastError() later on you get a spurious response and the socket operation looks like a fatal error. Really we shouldn't be logging an error anyway if its a retryable issue. Otherwise we could end up with stale errors on the error queue. Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Mat authored
verified that build succeeds without the extra define Reviewed-by:
Richard Levitte <levitte@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Mat authored
Fix no-blake2 for Windows classic build Reviewed-by:
Richard Levitte <levitte@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Dr. Stephen Henson authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Dr. Stephen Henson authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Richard Levitte authored
The issue is demonstrated as follows: On Linux: $ echo ': foo.h /usr/include/stddef.h bar.h' | sed -e 's/ \/\(\\.\|[^ ]\)*//g' : foo.h bar.h On MacOS X: $ echo ': foo.h /usr/include/stddef.h bar.h' | sed -e 's/ \/\(\\.\|[^ ]\)*//g' : foo.husr/include/stddef.h bar.h Perl is more consistent: On Linux: $ echo ': foo.h /usr/include/stddef.h bar.h' | perl -pe 's/ \/(\\.|[^ ])*//g;' : foo.h bar.h On MacOS X: $ echo ': foo.h /usr/include/stddef.h bar.h' | perl -pe 's/ \/(\\.|[^ ])*//g;' : foo.h bar.h Reviewed-by:
Andy Polyakov <appro@openssl.org>
-
Rich Salz authored
Reviewed-by:
Emilia Käsper <emilia@openssl.org>
-
Kurt Roeckx authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Kurt Roeckx authored
They are not numbers in the machine byte order. Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Kurt Roeckx authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Bill Cox authored
Reviewed-by:
Andy Polyakov <appro@openssl.org> Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Dr. Stephen Henson authored
Reviewed-by:
Rich Salz <rsalz@openssl.org>
-
Andy Polyakov authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-
Andy Polyakov authored
Reviewed-by:
Richard Levitte <levitte@openssl.org>
-