Skip to content
  1. Feb 01, 2019
  2. Jan 31, 2019
  3. Jan 30, 2019
  4. Jan 29, 2019
  5. Jan 28, 2019
  6. Jan 27, 2019
  7. Jan 25, 2019
  8. Jan 24, 2019
  9. Jan 22, 2019
  10. Jan 21, 2019
  11. Jan 16, 2019
  12. Jan 15, 2019
  13. Jan 08, 2019
    • Matt Caswell's avatar
      Don't artificially limit the size of the ClientHello · bbcfd60e
      Matt Caswell authored
      
      
      We were setting a limit of SSL3_RT_MAX_PLAIN_LENGTH on the size of the
      ClientHello. AFAIK there is nothing in the standards that requires this
      limit.
      
      The limit goes all the way back to when support for extensions was first
      added for TLSv1.0. It got converted into a WPACKET max size in 1.1.1. Most
      likely it was originally added to avoid the complexity of having to grow
      the init_buf in the middle of adding extensions. With WPACKET this is
      irrelevant since it will grow automatically.
      
      This issue came up when an attempt was made to send a very large
      certificate_authorities extension in the ClientHello.
      
      We should just remove the limit.
      
      Reviewed-by: default avatarPaul Dale <paul.dale@oracle.com>
      Reviewed-by: default avatarViktor Dukhovni <viktor@openssl.org>
      (Merged from https://github.com/openssl/openssl/pull/7424)
      
      (cherry picked from commit 7835e97b6ff5cd94a10c5aeac439f4aa145a77b2)
      bbcfd60e
    • FdaSilvaYY's avatar
      Fix CID 1434549: Unchecked return value in test/evp_test.c · 37cad7e6
      FdaSilvaYY authored
      
      
      5. check_return: Calling EVP_EncodeUpdate without checking return value
      (as is done elsewhere 4 out of 5 times).
      
      Fix CID 1371695, 1371698: Resource leak in test/evp_test.c
      
      - leaked_storage: Variable edata going out of scope leaks the storage it
      points to.
      
      - leaked_storage: Variable encode_ctx going out of scope leaks the
      storage it points to
      
      Fix CID 1430437, 1430426, 1430429 : Dereference before null check in test/drbg_cavs_test.c
      
      check_after_deref: Null-checking drbg suggests that it
      may be null, but it has already been dereferenced on all paths leading
      to the check
      
      Fix CID 1440765: Dereference before null check in test/ssltestlib.c
      
      check_after_deref: Null-checking ctx suggests that it may be null, but
      it has already been dereferenced on all paths leading to the check.
      
      Reviewed-by: default avatarMatt Caswell <matt@openssl.org>
      Reviewed-by: default avatarPaul Dale <paul.dale@oracle.com>
      Reviewed-by: default avatarMatthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
      Reviewed-by: default avatarBernd Edlinger <bernd.edlinger@hotmail.de>
      (Merged from https://github.com/openssl/openssl/pull/7993)
      
      (cherry picked from commit 760e2d60e62511a6fb96f547f6730d05eb5f47ec)
      37cad7e6
  14. Jan 07, 2019