- Jul 22, 2016
-
-
Dr. Stephen Henson authored
TS_OBJ_print_bio() misuses OBJ_txt2obj: it should print the result as a null terminated buffer. The length value returned is the total length the complete text reprsentation would need not the amount of data written. CVE-2016-2180 Thanks to Shi Lei for reporting this bug. Reviewed-by:Matt Caswell <matt@openssl.org>
-
Emilia Kasper authored
Don't emit duplicate server/client sections when they are identical. Instead, just point to the same section. Reviewed-by:Rich Salz <rsalz@openssl.org>
-
Emilia Kasper authored
Undo review mistake: I changed the wrong strcmp in a previous pull request. Add test. Reviewed-by: -
Dr. Stephen Henson authored
RT#4603 Reviewed-by: -
Dr. Stephen Henson authored
Reviewed-by: -
Dr. Stephen Henson authored
Reviewed-by: -
Dr. Stephen Henson authored
Reviewed-by: -
Richard Levitte authored
Reviewed-by: -
Richard Levitte authored
The way it was implemented before this change, the shared libraries were installed twice. On a file system that supports file generations, that's a waste. Slightly rearranging the install targets solves the problem. Reviewed-by:
-
- Jul 21, 2016
-
-
Emilia Kasper authored
Add tests for resuming with a different client version. This happens in reality when clients persist sessions on disk through upgrades. Reviewed-by:
-
- Jul 20, 2016
-
-
Kurt Roeckx authored
Reviewed-by: -
Kurt Roeckx authored
llvm's ubsan reported: runtime error: negation of -9223372036854775808 cannot be represented in type 'long'; cast to an unsigned type to negate this value to itself Found using afl Reviewed-by: -
Kurt Roeckx authored
Reviewed-by:Richard Levitte <levitte@openssl.org> GH: #1330
-
Dr. Stephen Henson authored
To avoid having to immediately free up r/s when setting them don't allocate them automatically in DSA_SIG_new() and ECDSA_SIG_new(). RT#4590 Reviewed-by: -
Richard Levitte authored
On non-Windows platforms, shared libraries are both development and runtime files. We only installed them as development files, this makes sure they get installed as runtime files as well. Reviewed-by: -
Richard Levitte authored
Reviewed-by: -
Matt Caswell authored
This is adapted from BoringSSL commit 2f87112b963. This fixes a number of bugs where the existence of bbio was leaked in the public API and broke things. - SSL_get_wbio returned the bbio during the handshake. It must always return the BIO the consumer configured. In doing so, some internal accesses of SSL_get_wbio should be switched to ssl->wbio since those want to see bbio. - The logic in SSL_set_rfd, etc. (which I doubt is quite right since SSL_set_bio's lifetime is unclear) would get confused once wbio got wrapped. Those want to compare to SSL_get_wbio. - If SSL_set_bio was called mid-handshake, bbio would get disconnected and lose state. It forgets to reattach the bbio afterwards. Unfortunately, Conscrypt does this a lot. It just never ended up calling it at a point where the bbio would cause problems. - Make more explicit the invariant that any bbio's which exist are always attached. Simplify a few things as part of that. RT#4572 Reviewed-by: -
Emilia Kasper authored
Systematically test every server-side version downgrade or upgrade. Client version upgrade or downgrade could be tested analogously but will be done in a later change. Reviewed-by:
-
Dr. Stephen Henson authored
Reviewed-by: -
FdaSilvaYY authored
Reviewed-by:
-
FdaSilvaYY authored
Fix some indentation at the same time Reviewed-by:
-
Hannes Magnusson authored
f0e0fd51 added X509_STORE_CTX_set_verify_cb with a typedef'd argument, making the original one redundant. Reviewed-by:
-
FdaSilvaYY authored
Reviewed-by:
-
FdaSilvaYY authored
Fix some code indentation Reviewed-by:
-
FdaSilvaYY authored
Reviewed-by:
-
FdaSilvaYY authored
Reviewed-by:
-
FdaSilvaYY authored
Reviewed-by:
-
Todd Short authored
There are two failure cases for OCSP_request_add_id(): 1. OCSP_ONEREQ_new() failure, where |cid| is not freed 2. sk_OCSP_ONEREQ_push() failure, where |cid| is freed This changes makes the error behavior consistent, such that |cid| is not freed when sk_OCSP_ONEREQ_push() fails. OpenSSL only takes ownership of |cid| when the function succeeds. Reviewed-by:
-
- Jul 19, 2016
-
-
Dr. Stephen Henson authored
RT#4600 Reviewed-by: -
Dr. Stephen Henson authored
RT#4610 Reviewed-by: -
Coty Sutherland authored
Reviewed-by:
-
Richard Levitte authored
Reviewed-by:Kurt Roeckx <kurt@openssl.org>
-
Richard Levitte authored
Reviewed-by: -
Richard Levitte authored
Reviewed-by: -
Richard Levitte authored
That way, we have a way to check if the init function was successful or not. Reviewed-by: -
Richard Levitte authored
Because pthread_once() takes a function taking no argument and returning nothing, and we want to be able to check if they're successful, we define a few internal macros to get around the issue. Reviewed-by: -
Rich Salz authored
Update find-doc-nits to find errors in SYNOPSIS (the most common place where they were missing). Reviewed-by: -
Richard Levitte authored
Reviewed-by: -
Matt Caswell authored
The new fuzzing code broke no-cms Reviewed-by: -
Richard Levitte authored
Reviewed-by:
-
