chore: run Robotidy on all TCs and resources files

Benoit Orihuelarequested to merge
chore/integrate-robotidy-tool into develop
  • Format all existing code with Robotidy
  • Add a pre-commit hook to automatically format the code
  • Add sample Pycharm run configurations to check and format files
Edited by Benoit Orihuela

Merge request reports

.idea/runConfigurations/Check_Format.xml

0 → 100644
+24 −0
Changes for .idea/runConfigurations/Check_Format.xml: 24 added lines, 0 removed lines.
Original line number Diff line number Diff line 
<component name="ProjectRunConfigurationManager">

  <configuration default="false" name="Check Format" type="PythonConfigurationType" factoryName="Python">

    <log_file alias="robotidy" path="$PROJECT_DIR$/robotidy" />

    <module name="ngsi-ld-test-suite" />

    <option name="INTERPRETER_OPTIONS" value="" />

    <option name="PARENT_ENVS" value="true" />

    <envs>

      <env name="PYTHONUNBUFFERED" value="1" />

    </envs>

    <option name="SDK_HOME" value="$PROJECT_DIR$/venv/bin/python" />

    <option name="WORKING_DIRECTORY" value="" />

    <option name="IS_MODULE_SDK" value="true" />

    <option name="ADD_CONTENT_ROOTS" value="true" />

    <option name="ADD_SOURCE_ROOTS" value="true" />

    <option name="SCRIPT_NAME" value="robotidy" />

    <option name="PARAMETERS" value="--check $ContentRoot$" />

    <option name="SHOW_COMMAND_LINE" value="false" />

    <option name="EMULATE_TERMINAL" value="true" />

    <option name="MODULE_MODE" value="true" />

    <option name="REDIRECT_INPUT" value="false" />

    <option name="INPUT_FILE" value="" />

    <method v="2" />

  </configuration>

</component>
 
 No newline at end of file

.idea/runConfigurations/Format_Files.xml

0 → 100644
+23 −0

File added.

Generated files are collapsed by default. To change this behavior, edit the .gitattributes file. Learn more.

TP/NGSI-LD/CommonBehaviours/043.robot

+32 −15
Changes for TP/NGSI-LD/CommonBehaviours/043.robot: 32 added lines, 15 removed lines.
Original line number Diff line number Diff line 
*** Settings ***

Documentation     Verify throwing 503 – LDContextNotAvaliable error if remote JSON-LD @context cannot be retrieved

Documentation       Verify throwing 503 – LdContextNotAvailable error if remote JSON-LD @context cannot be retrieved



Resource            ${EXECDIR}/resources/ApiUtils.resource

Resource            ${EXECDIR}/resources/AssertionUtils.resource

Resource            ${EXECDIR}/resources/JsonUtils.resource



*** Variable ***



*** Variables ***

${expected_status_code}=        503

${building_id_prefix}=          urn:ngsi-ld:Building:

${building_filename}=           building-unretrievable-context-sample.jsonld
@@ -15,39 +17,52 @@ ${tea_filename}= bus-temporal-representation-unretrievable-context-sample.jso 
${registration_id_prefix}=      urn:ngsi-ld:Registration:

${registration_filename}=       csourceRegistrations/context-source-registration-unretrievable-context-sample.jsonld





*** Test Cases ***

043_01 Create entity

    [Documentation]    Verify throwing 503 – LDContextNotAvaliable error if remote JSON-LD @context cannot be retrieved (Create entity)

    [Documentation]    Verify throwing 503 – LdContextNotAvailable error if remote JSON-LD @context cannot be retrieved (Create entity)

    [Tags]    e-create    5_2_2

    ${entity_id}=    Generate Random Entity Id    ${building_id_prefix}

    ${request}    ${response}=    Create Entity Selecting Content Type    ${building_filename}    ${entity_id}    ${CONTENT_TYPE_LD_JSON}

    ${request}    ${response}=    Create Entity Selecting Content Type

    ...    ${building_filename}

    ...    ${entity_id}

    ...    ${CONTENT_TYPE_LD_JSON}

    Check Response Status Code    ${expected_status_code}    ${response['status']}

    Check Response Body Containing ProblemDetails Element Containing Type Element set to    ${response}    ${ERROR_TYPE_LD_CONTEXT_NOT_AVAILABLE}

    Check Response Body Containing ProblemDetails Element Containing Type Element set to

    ...    ${response}

    ...    ${ERROR_TYPE_LD_CONTEXT_NOT_AVAILABLE}

    Check Response Body Containing ProblemDetails Element Containing Title Element    ${response}

    [Teardown]    Delete Entity by Id    ${entity_id}



043_02 Create subscription

    [Documentation]    Verify throwing 503 – LDContextNotAvaliable error if remote JSON-LD @context cannot be retrieved (Create subscription)

    [Documentation]    Verify throwing 503 – LdContextNotAvailable error if remote JSON-LD @context cannot be retrieved (Create subscription)

    [Tags]    sub-create    5_2_2

    ${subscription_id}=    Generate Random Entity Id    ${subscription_id_prefix}

    ${response}=    Create Subscription    ${subscription_id}    ${subscription_filename}    ${CONTENT_TYPE_LD_JSON}

    Check Response Status Code    ${expected_status_code}    ${response['status']}

    Check Response Body Containing ProblemDetails Element Containing Type Element set to    ${response}    ${ERROR_TYPE_LD_CONTEXT_NOT_AVAILABLE}

    Check Response Body Containing ProblemDetails Element Containing Type Element set to

    ...    ${response}

    ...    ${ERROR_TYPE_LD_CONTEXT_NOT_AVAILABLE}

    Check Response Body Containing ProblemDetails Element Containing Title Element    ${response}

    [Teardown]    Delete Subscription    ${subscription_id}



043_03 Create Temporal Representation of Entities

    [Documentation]    Verify throwing 503 – LDContextNotAvaliable error if remote JSON-LD @context cannot be retrieved (Create Temporal Representation of Entities)

    [Documentation]    Verify throwing 503 – LdContextNotAvailable error if remote JSON-LD @context cannot be retrieved (Create Temporal Representation of Entities)

    [Tags]    te-create    5_2_2

    ${temporal_entity_representation_id}=    Generate Random Entity Id    ${tea_id_prefix}

    ${response}=    Create Or Update Temporal Representation Of Entity Selecting Content Type    ${temporal_entity_representation_id}    ${tea_filename}    ${CONTENT_TYPE_LD_JSON}

    ${response}=    Create Or Update Temporal Representation Of Entity Selecting Content Type

    ...    ${temporal_entity_representation_id}

    ...    ${tea_filename}

    ...    ${CONTENT_TYPE_LD_JSON}

    Check Response Status Code    ${expected_status_code}    ${response['status']}

    Check Response Body Containing ProblemDetails Element Containing Type Element set to    ${response}    ${ERROR_TYPE_LD_CONTEXT_NOT_AVAILABLE}

    Check Response Body Containing ProblemDetails Element Containing Type Element set to

    ...    ${response}

    ...    ${ERROR_TYPE_LD_CONTEXT_NOT_AVAILABLE}

    Check Response Body Containing ProblemDetails Element Containing Title Element    ${response}

    [Teardown]    Delete Temporal Representation Of Entity    ${temporal_entity_representation_id}



043_04 Batch entity create

    [Documentation]    Verify throwing 503 – LDContextNotAvaliable error if remote JSON-LD @context cannot be retrieved (Batch entity create)

    [Documentation]    Verify throwing 503 – LdContextNotAvailable error if remote JSON-LD @context cannot be retrieved (Batch entity create)

    [Tags]    be-create    5_2_2

    ${first_entity_id}=    Generate Random Entity Id    ${building_id_prefix}

    ${second_entity_id}=    Generate Random Entity Id    ${building_id_prefix}
@@ -56,16 +71,18 @@ ${registration_filename}= csourceRegistrations/context-source-registration-un 
    @{entities_to_be_created}=    Create List    ${first_entity}    ${second_entity}

    Batch Create Entities    @{entities_to_be_created}    content_type=${CONTENT_TYPE_LD_JSON}

    Check Response Status Code Set To    ${expected_status_code}

    Check Response Body Containing ProblemDetails Element Containing Type Element set to    ${response}    ${ERROR_TYPE_LD_CONTEXT_NOT_AVAILABLE}

    Check Response Body Containing ProblemDetails Element Containing Type Element set to

    ...    ${response}

    ...    ${ERROR_TYPE_LD_CONTEXT_NOT_AVAILABLE}

    Check Response Body Containing ProblemDetails Element Containing Title Element    ${response}

    [Teardown]    Batch Delete Entities    @{entities_to_be_created}



043_05 Create context source registration

    [Documentation]    Verify throwing 503 – LDContextNotAvaliable error if remote JSON-LD @context cannot be retrieved (Create context source registration)

    [Documentation]    Verify throwing 503 – LdContextNotAvailable error if remote JSON-LD @context cannot be retrieved (Create context source registration)

    [Tags]    csr-create    5_2_2

    ${registration_id}=    Generate Random Entity Id    ${registration_id_prefix}

    ${payload}=    Load Json From File    ${EXECDIR}/data/${registration_filename}

    ${updated_payload}=    Update Value To Json    ${payload}    $..id    ${registration_id}

    ${payload}=    Load JSON From File    ${EXECDIR}/data/${registration_filename}

    ${updated_payload}=    Update Value To JSON    ${payload}    $..id    ${registration_id}

    ${request}    ${response}=    Create Context Source Registration With Return    ${updated_payload}

    Check Response Status Code    ${expected_status_code}    ${response['status']}

    Check Response Headers Containing URI set to    ${request['path']}/    ${registration_id}    ${response}

TP/NGSI-LD/CommonBehaviours/044_01.robot

+19 −4
Changes for TP/NGSI-LD/CommonBehaviours/044_01.robot: 19 added lines, 4 removed lines.
Original line number Diff line number Diff line 
*** Settings ***

Documentation       Verify that PATCH HTTP requests can be done with "application/merge-patch+json" as Content-Type



Resource            ${EXECDIR}/resources/ApiUtils.resource

Resource            ${EXECDIR}/resources/AssertionUtils.resource

Resource            ${EXECDIR}/resources/JsonUtils.resource



*** Variable ***



*** Variables ***

${vehicle_id_prefix}=           urn:ngsi-ld:Vehicle:

${vehicle_filename}=            vehicle-simple-attributes-sample.jsonld

${vehicle_fragment}=            vehicle-brandname-fragment.json
@@ -13,14 +15,23 @@ ${subscription_id_prefix}= urn:ngsi-ld:Subscription: 
${subscription_filename}=       subscriptions/subscription-sample.jsonld

${subscription_fragment}=       subscriptions/fragments/subscription-update-sample.json





*** Test Cases ***

044_01_01_endpoint /entities/{entityId}/attrs/{attrId}

    [Documentation]    Verify that PATCH HTTP requests can be done with "application/merge-patch+json" as Content-Type

    [Tags]    ea-partial-update    6_3_4

    ${entity_id}=    Generate Random Entity Id    ${vehicle_id_prefix}

    ${request}    ${response}=    Create Entity Selecting Content Type    ${vehicle_filename}    ${entity_id}    ${CONTENT_TYPE_LD_JSON}

    ${request}    ${response}=    Create Entity Selecting Content Type

    ...    ${vehicle_filename}

    ...    ${entity_id}

    ...    ${CONTENT_TYPE_LD_JSON}

    Check Response Status Code    201    ${response['status']}

    ${response}=    Partial Update Entity Attributes    ${entity_id}    ${attribute_id}    ${vehicle_fragment}    ${CONTENT_TYPE_MERGE_PATCH_JSON}    context=${ngsild_test_suite_context}

    ${response}=    Partial Update Entity Attributes

    ...    ${entity_id}

    ...    ${attribute_id}

    ...    ${vehicle_fragment}

    ...    ${CONTENT_TYPE_MERGE_PATCH_JSON}

    ...    context=${ngsild_test_suite_context}

    Check Response Status Code    204    ${response['status']}

    [Teardown]    Delete Entity by Id    ${entity_id}
@@ -30,6 +41,10 @@ ${subscription_fragment}= subscriptions/fragments/subscription-update-sample. 
    ${subscription_id}=    Generate Random Entity Id    ${subscription_id_prefix}

    ${response}=    Create Subscription    ${subscription_id}    ${subscription_filename}    ${CONTENT_TYPE_LD_JSON}

    Check Response Status Code    201    ${response['status']}

    ${response}=    Update Subscription    ${subscription_id}    ${subscription_fragment}    ${CONTENT_TYPE_MERGE_PATCH_JSON}    context=${ngsild_test_suite_context}

    ${response}=    Update Subscription

    ...    ${subscription_id}

    ...    ${subscription_fragment}

    ...    ${CONTENT_TYPE_MERGE_PATCH_JSON}

    ...    context=${ngsild_test_suite_context}

    Check Response Status Code    204    ${response['status']}

    [Teardown]    Delete Subscription    ${subscription_id}

TP/NGSI-LD/CommonBehaviours/044_02.robot

+25 −7
Changes for TP/NGSI-LD/CommonBehaviours/044_02.robot: 25 added lines, 7 removed lines.
Original line number Diff line number Diff line 
*** Settings ***

Documentation       Verify that on a GET HTTP request if nothing is specified on the Accept header, "application/json" is assumed



Resource            ${EXECDIR}/resources/ApiUtils.resource

Resource            ${EXECDIR}/resources/AssertionUtils.resource

Resource            ${EXECDIR}/resources/JsonUtils.resource



*** Variable ***



*** Variables ***

${building_id_prefix}=          urn:ngsi-ld:Building:

${building_filename}=           building-simple-attributes-sample.jsonld

${subscription_id_prefix}=      urn:ngsi-ld:Subscription:
@@ -17,12 +19,16 @@ ${tea_filename}= vehicle-temporal-representation-sample.jsonld 
${teatype}=                     Vehicle

${content_type}=                application/json





*** Test Cases ***

044_02_01_endpoint /entities/{entityId}

    [Documentation]    Verify that on a GET HTTP request if nothing is specified on the Accept header, "application/json" is assumed (/entities/{entityId})

    [Tags]    e-query    6_3_4

    ${id}=    Generate Random Entity Id    ${building_id_prefix}

    ${request}    ${response}=    Create Entity Selecting Content Type    ${building_filename}    ${id}    ${CONTENT_TYPE_LD_JSON}

    ${request}    ${response}=    Create Entity Selecting Content Type

    ...    ${building_filename}

    ...    ${id}

    ...    ${CONTENT_TYPE_LD_JSON}

    Check Response Status Code    201    ${response['status']}

    ${request}    ${response}=    Query Entity    ${id}    context=${ngsild_test_suite_context}    accept=*/*

    Check Response Status Code    200    ${response['status']}
@@ -46,11 +52,15 @@ ${content_type}= application/json 
    [Documentation]    Verify that on a GET HTTP request if nothing is specified on the Accept header, "application/json" is assumed (/csourceRegistrations/)

    [Tags]    csr-query    6_3_4

    ${registration_id}=    Generate Random Entity Id    ${registration_id_prefix}

    ${payload}=    Load Json From File    ${EXECDIR}/data/${registration_filename}

    ${updated_payload}=    Update Value To Json    ${payload}    $..id    ${registration_id}

    ${payload}=    Load JSON From File    ${EXECDIR}/data/${registration_filename}

    ${updated_payload}=    Update Value To JSON    ${payload}    $..id    ${registration_id}

    ${request}    ${response}=    Create Context Source Registration With Return    ${updated_payload}

    Check Response Status Code    201    ${response['status']}

    ${request}    ${response}=    Query Context Source Registrations With Return    id=${registration_id}    type=${registration_type}    context=${ngsild_test_suite_context}    accept=*/*

    ${request}    ${response}=    Query Context Source Registrations With Return

    ...    id=${registration_id}

    ...    type=${registration_type}

    ...    context=${ngsild_test_suite_context}

    ...    accept=*/*

    Check Response Status Code    200    ${response['status']}

    Check Response Headers Containing Content-Type set to    ${response}    ${content_type}

    Check Response Headers Link Not Empty    ${response}
@@ -60,9 +70,17 @@ ${content_type}= application/json 
    [Documentation]    Verify that on a GET HTTP request if nothing is specified on the Accept header, "application/json" is assumed (/temporal/entities)

    [Tags]    te-query    6_3_4

    ${temporal_entity_representation_id}=    Generate Random Entity Id    ${tea_id_prefix}

    ${response}=    Create Or Update Temporal Representation Of Entity Selecting Content Type    ${temporal_entity_representation_id}    ${tea_filename}    ${CONTENT_TYPE_LD_JSON}

    ${response}=    Create Or Update Temporal Representation Of Entity Selecting Content Type

    ...    ${temporal_entity_representation_id}

    ...    ${tea_filename}

    ...    ${CONTENT_TYPE_LD_JSON}

    Check Response Status Code    201    ${response['status']}

    ${request}    ${response}=    Query Temporal Representation Of Entities With Return    entity_types=${teatype}    timerel=after    timeAt=2020-08-01T12:05:00Z    context=${ngsild_test_suite_context}    accept=*/*

    ${request}    ${response}=    Query Temporal Representation Of Entities With Return

    ...    entity_types=${teatype}

    ...    timerel=after

    ...    timeAt=2020-08-01T12:05:00Z

    ...    context=${ngsild_test_suite_context}

    ...    accept=*/*

    Check Response Status Code    200    ${response['status']}

    Set Test Variable    ${response}

    Check Response Headers Containing Content-Type set to    ${response}    ${content_type}