SOL003 VNF Indicator - Implementation of deltas between v3.5.1 and v3.3.1

Giacomo Berninirequested to merge
3.5.1-dev-SOL003-VNF-IND into 3.5.1-dev

This merge request refers to the implementation of deltas between v3.5.1 and v3.3.1 of SOL003 VNF Indicator Interface.

@lynchpi @aelken @matsuurat @sayama @kraja @zafar @abbasim @muhammadh

Deadline for review: Friday 5th November 2021 @6pm CEST

Review period elapsed: Approved !

Edited by Giacomo Bernini

Merge request reports

SOL003/VNFIndicator-API/environment/variables.txt

+0 −7
Changes for SOL003/VNFIndicator-API/environment/variables.txt: 0 added lines, 7 removed lines.
Original line number Diff line number Diff line
@@ -15,18 +15,12 @@ ${apiRoot} / 
${apiMajorVersion}     v1

${apiName}        vnfind



${VNFM_CHECKS_NOTIF_ENDPOINT}    1        ## If true, during subscription, the FUT performs a get to the notification endpoint



${VNFM_ALLOWS_DUPLICATE_SUBS}    1



${response}



${callback_uri}    http://localhost

${callback_port}    9091

${callback_endpoint}    /endpoint

${callback_endpoint_fwd}    /endpoint/check

${callback_endpoint_error}    /endpoint_404

${sleep_interval}    20s

${total_polling_time}   2 min

${polling_interval}     10 sec
@@ -38,7 +32,6 @@ ${MOCK_SERVER_JAR} ../../../bin/mockserver-netty-5.5.0-jar-with-dependencies. 


${subscriptionId}    17563e75-0e14-4bd7-94b4-6bbb869c79aa

${erroneousSubscriptionId}    erroneousSubscriptionId

${newSubscriptionId}    newSubsciptionId

${origResponse}    httpresponse

SOL003/VNFIndicator-API/IndividualSubscription.robot

+7 −7
Changes for SOL003/VNFIndicator-API/IndividualSubscription.robot: 7 added lines, 7 removed lines.
Original line number Diff line number Diff line
@@ -11,7 +11,7 @@ GET Individual VNF Indicator Subscription 
    ...    Test title: GET Individual VNF Indicator Subscription

    ...    Test objective: The objective is to test the retrieval of individual VNF indicator subscription and perform a JSON schema validation of the returned subscription data structure

    ...    Pre-conditions: A VNF instance is instantiated. At least one VNF indicator subscription is available in the VNFM.

    ...    Reference: Clause 8.4.6.3.2 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.6.3.2 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: none
@@ -24,7 +24,7 @@ GET Individual VNF Indicator Subscription with invalid resource identifier 
    ...    Test title: GET Individual VNF Indicator Subscription with invalid resource identifier

    ...    Test objective: The objective is to test that the retrieval of individual VNF indicator subscription fails when using an invalid resource identifier.

    ...    Pre-conditions: A VNF instance is instantiated. At least one VNF indicator subscription is available in the VNFM.

    ...    Reference: Clause 8.4.6.3.2 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.6.3.2 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: none
@@ -37,7 +37,7 @@ DELETE Individual VNF Indicator Subscription 
    ...    Test title: DELETE Individual VNF Indicator Subscription

    ...    Test objective: The objective is to test the deletion of an individual VNF indicator subscription.

    ...    Pre-conditions: A VNF instance is instantiated. At least one VNF indicator subscription is available in the VNFM.

    ...    Reference: Clause 8.4.6.3.5 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.6.3.5 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: The subscription to VNF indicators is deleted
@@ -50,7 +50,7 @@ DELETE Individual VNF Indicator Subscription with invalid resource identifier 
    ...    Test title: DELETE Individual VNF Indicator Subscription with invalid resource identifier

    ...    Test objective: The objective is to test that the deletion of an individual VNF indicator subscription fails when using an invalid resource identifier.

    ...    Pre-conditions: A VNF instance is instantiated. At least one VNF indicator subscription is available in the VNFM.

    ...    Reference: Clause 8.4.6.3.5 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.6.3.5 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: none
@@ -62,7 +62,7 @@ PUT Individual VNF Indicator Subscription - Method not implemented 
    ...    Test title: PUT Individual VNF Indicator Subscription - Method not implemented

    ...    Test objective: The objective is to test that PUT method is not allowed to modify an individual VNF indicator subscription

    ...    Pre-conditions: A VNF instance is instantiated. At least one VNF indicator subscription is available in the VNFM.

    ...    Reference: Clause 8.4.6.3.3 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.6.3.3 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: The individual VNF indicator subscription is not modified by the operation
@@ -74,7 +74,7 @@ PATCH Individual VNF Indicator Subscription - Method not implemented 
    ...    Test title: PATCH Individual VNF Indicator Subscription - Method not implemented

    ...    Test objective: The objective is to test that PATCH method is not allowed to update an individual VNF indicator subscription

    ...    Pre-conditions: A VNF instance is instantiated. At least one VNF indicator subscription is available in the VNFM.

    ...    Reference: Clause 8.4.6.3.4 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.6.3.4 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: none
@@ -86,7 +86,7 @@ POST Individual VNF Indicator Subscription - Method not implemented 
    ...    Test title: POST Individual VNF Indicator Subscription - Method not implemented

    ...    Test objective: The objective is to test that POST method is not allowed to create a new VNF indicator subscription

    ...    Pre-conditions: A VNF instance is instantiated.

    ...    Reference: Clause 8.4.6.3.1 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.6.3.1 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: none

SOL003/VNFIndicator-API/IndividualVNFindicator.robot

+6 −6
Changes for SOL003/VNFIndicator-API/IndividualVNFindicator.robot: 6 added lines, 6 removed lines.
Original line number Diff line number Diff line
@@ -10,7 +10,7 @@ Get Individual Indicator for VNF Instance 
    ...    Test title: Get Individual Indicator for VNF Instance

    ...    Test objective: The objective is to test the retrieval of an indicator for a given VNF instance and perform a JSON schema validation of the returned indicator data structure

    ...    Pre-conditions: A VNF instance is instantiated. At least one measure of VNF indicator is available in the VNFM.

    ...    Reference: Clause 8.4.4.3.2 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.4.3.2 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: none
@@ -25,7 +25,7 @@ Get Individual Indicator for VNF Instance with invalid indicator identifier 
    ...    Test title: Get Individual Indicator for VNF Instance with invalid indicator identifier

    ...    Test objective: The objective is to test that the retrieval of an indicator for a given VNF instance fails when using an invalid resource identifier. The test also checks the JSON schema of the unsuccessful operation HTTP response.

    ...    Pre-conditions: A VNF instance is instantiated. At least one measure of VNF indicator is available in the VNFM.

    ...    Reference: Clause 8.4.4.3.2 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.4.3.2 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: none
@@ -38,7 +38,7 @@ POST Individual VNF Indicator for VNF Instance - Method not implemented 
    ...    Test title: POST Individual VNF Indicator for VNF Instance - Method not implemented

    ...    Test objective: The objective is to test that POST method is not allowed to create a new VNF indicator in the VNFM

    ...    Pre-conditions: A VNF instance is instantiated.

    ...    Reference: Clause 8.4.4.3.1 - ETSI GS NFV-SOL 003 [1] v2.7.1

    ...    Reference: Clause 8.4.4.3.1 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: none
@@ -50,7 +50,7 @@ PUT Individual VNF Indicator for VNF Instance - Method not implemented 
    ...    Test title: PUT Individual VNF Indicator for VNF Instance - Method not implemented

    ...    Test objective: The objective is to test that PUT method is not allowed to modify an existing indicator for a VNF instance

    ...    Pre-conditions: A VNF instance is instantiated. At least one measure of VNF indicator is available in the VNFM

    ...    Reference: Clause 8.4.4.3.3 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.4.3.3 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: none
@@ -62,7 +62,7 @@ PATCH Individual VNF Indicator for VNF Instance - Method not implemented 
    ...    Test title: PATCH Individual VNF Indicator for VNF Instance - Method not implemented

    ...    Test objective: The objective is to test that PATCH method is not allowed to update an existing indicator for a VNF instance

    ...    Pre-conditions: A VNF instance is instantiated. At least one measure of VNF indicator is available for the given VNF instance.

    ...    Reference: Clause 8.4.4.3.4 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.4.3.4 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: none
@@ -74,7 +74,7 @@ DELETE Individual VNF Indicator for VNF Instance - Method not implemented 
    ...    Test title: DELETE Individual VNF Indicator for VNF Instance - Method not implemented

    ...    Test objective: The objective is to test that DELETE method is not allowed to delete an existing indicator for a VNF instance

    ...    Pre-conditions: A VNF instance is instantiated. At least one measure of VNF indicator is available in the VNFM

    ...    Reference: Clause 8.4.3.3.5 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.3.3.5 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: none

SOL003/VNFIndicator-API/NotificationEndpoint.robot

+2 −2
Changes for SOL003/VNFIndicator-API/NotificationEndpoint.robot: 2 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ VNF Indicator Value Change Notification 
    ...    Test title: VNF Indicator Value Change Notification

    ...    Test objective: The objective is to test that the POST request triggers VNF Indicator Value Change Notification.

    ...    Pre-conditions: A VNF is instantiated, and a subscription for indicator value change notifications is available in the VNFM.

    ...    Reference: Clause 8.4.7.3.1 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.7.3.1 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_Notif_Endpoint

    ...    Applicability: none

    ...    Post-Conditions: none
@@ -24,7 +24,7 @@ Supported Indicators Change Notification 
    ...    Test title: Supported Indicators Change Notification

    ...    Test objective: The objective is to test that the POST request triggers Supported Indicators Change Notification.

    ...    Pre-conditions: A VNF is instantiated, and a individual subscription resource for supported indicators change notifications is available in the VNFM.

    ...    Reference: Clause 8.4.7.3.1 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.7.3.1 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_Notif_Endpoint

    ...    Applicability: none

    ...    Post-Conditions: none

SOL003/VNFIndicator-API/Notifications.robot

+1 −1
Changes for SOL003/VNFIndicator-API/Notifications.robot: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ VNF Indicator Value Change Notification 
    ...    Test title: VNF Indicator Value Change Notification

    ...    Test objective: The objective is to test the dispatch of VNF Indicator Value Change Notification when new indicator values are available in the VNFM, and perform a JSON schema and content validation of the delivered notification. The action that triggers the notification under test is an explicit test step, but it is not performed by the test system.

    ...    Pre-conditions: A VNF is instantiated, and a subscription for indicator value change notifications is available in the VNFM.

    ...    Reference: Clause 8.4.7.3.1 - ETSI GS NFV-SOL 003 [1] v3.3.1

    ...    Reference: Clause 8.4.7.3.1 - ETSI GS NFV-SOL 003 [1] v3.5.1

    ...    Config ID: Config_prod_VNFM

    ...    Applicability: none

    ...    Post-Conditions: none