Commit 431e0f81 authored by garciay's avatar garciay
Browse files

Session Week #35: 

- Remove TODOs
- Reduce FIXME
- Review PM test cases
- Start review of TM test cases
parent db2b5e2c

AtsGtpv2C_TestCases.ttcn

+39 −40
Original line number Diff line number Diff line
@@ -265,7 +265,7 @@ module AtsGtpv2C_TestCases { 
             * @desc    Validate that S-GW is able to request the MME to start Create Bearer Request Procedure.

             * <pre>

             * Pics Selection: PICS_S11_IUT_IS_MME and PICS_MME_CREATE_SESSION_REQUEST and PICS_MME_CREATE_BEARER_RESPONSE and PICS_MME_MODIFY_BEARER_REQUEST

             * Config Id: CF01

             * Config Id: CF02

             * Initial conditions:

             *  with {

             *      EPC, RAN, and one UE are available.
@@ -273,7 +273,6 @@ module AtsGtpv2C_TestCases { 
             *      S-GW is configured with the GTP Tunnel Parameter.

             *      Verify IP connectivity between the two nodes.

             *      UE attaches to the network. During the attach procedure the S-GW sends the Create Bearer Request message to the MME as part of the Dedicated Bearer Activation Procedure.

             *      The QoS parameter is updated in the P-GW. 

             *  }

             * Expected behaviour:

             *  ensure that {
@@ -291,7 +290,7 @@ module AtsGtpv2C_TestCases { 
             * @verdict pass on success, inconc on timeout, fail otherwise

             *

             * @see         ETSI TS 103 202-2 V0.0.2 (2014-03), TP_TM_02

             * @reference   ETSI TS 129 274, clauses 7.2.3, 7.2.4

             * @reference   ETSI TS 129 274, clauses 7.2.3 * 7.2.4

             * @reference   ETSI TS 123.401, clauses 5.4.1

             */

            testcase TC_S11_MME_TM_02() runs on Gtpv2CComponent system Gtpv2CSystemAdapter {
@@ -375,7 +374,7 @@ module AtsGtpv2C_TestCases { 
            } // End of testcase TC_S11_MME_TM_03 

            

            /**

             * @desc    Validate that a Bearer Resource Command message shall be sent from a MME to a S-GW and forwarded to the PDN-GW as a part of the UE requested bearer resource allocation procedure or UE requested bearer resource modification procedure.

             * @desc    Validate that a Bearer Resource Failure Indication shall be sent by the PDN-GW to an S-GW and forwarded to the MME to indicate failure of the UE requested bearer resource allocation procedure or UE requested bearer resource modification procedure

             * <pre>

             * Pics Selection: PICS_S11_IUT_IS_MME and PICS_MME_BEARER_RESOURCE_COMMAND

             * Config Id: CF01
@@ -542,7 +541,7 @@ module AtsGtpv2C_TestCases { 
             * @desc    Verify that the Serving GW sends a Downlink Data Notification message to the MME for which it has control plane connectivity for a given UE

             * <pre>

             * Pics Selection: PICS_S11_IUT_IS_MME and PICS_MME_DOWNLINK_DATA_NOTIFICATION_ACKNOWLEDGE

             * Config Id: CF02

             * Config Id: CF01

             * Initial conditions:

             *  with {

             *      EPC, RAN, and one UE is required.
@@ -579,17 +578,16 @@ module AtsGtpv2C_TestCases { 
                }

                

                // Test component configuration

                f_cf02_S11Up_MME();

                f_cf01_S11Up_MME();

                

                // Start

                vc_s1mme.start(f_TC_S1_MME_TM_07());

                vc_sgw.start(f_TC_S11_MME_TM_07());

                

                // synchronize PTC on 2 sychronization point(s)

                f_serverSyncNClientsAndStop(2, { c_prDone, c_tbDone, c_poDone });

                // synchronize PTC on 1 sychronization point(s)

                f_serverSyncNClientsAndStop(1, { c_prDone, c_tbDone, c_poDone });

                

                // Postamble

                f_cf02_S11Down_MME();

                f_cf01_S11Down_MME();

                

            } // End of testcase TC_S11_MME_TM_07
@@ -597,7 +595,7 @@ module AtsGtpv2C_TestCases { 
             * @desc    Verify that a Downlink Data Notification Failure indication is sent from an MME/SGSN to an S-GW 

             * <pre>

             * Pics Selection: PICS_S11_IUT_IS_MME and PICS_MME_DOWNLINK_DATA_FAILURE_INDICATION

             * Config Id: CF02

             * Config Id: CF01

             * Initial conditions:

             *  with {

             *      EPC, RAN, and one UE is required.
@@ -620,7 +618,7 @@ module AtsGtpv2C_TestCases { 
             * @verdict pass on success, inconc on timeout, fail otherwise

             *

             * @see         ETSI TS 103 202-2 V0.0.2 (2014-03), TP_TM_08

             * @reference   ETSI TS 129 274, clauses 7.2.11.1 & 7.2.11.2

             * @reference   ETSI TS 129 274, clauses 7.2.11.3

             * @reference   ETSI TS 123.401, clauses 5.3.4.3

             */

            testcase TC_S11_MME_TM_08() runs on Gtpv2CComponent system Gtpv2CSystemAdapter {
@@ -635,17 +633,16 @@ module AtsGtpv2C_TestCases { 
                }

                

                // Test component configuration

                f_cf02_S11Up_MME();

                f_cf01_S11Up_MME();

                

                // Start

                vc_s1mme.start(f_TC_S1_MME_TM_08());

                vc_sgw.start(f_TC_S11_MME_TM_08());

                

                // synchronize PTC on 2 sychronization point(s)

                f_serverSyncNClientsAndStop(2, { c_prDone, c_tbDone, c_poDone });

                // synchronize PTC on 1 sychronization point(s)

                f_serverSyncNClientsAndStop(1, { c_prDone, c_tbDone, c_poDone });

                

                // Postamble

                f_cf02_S11Down_MME();

                f_cf01_S11Down_MME();

                

            } // End of testcase TC_S11_MME_TM_08
@@ -821,7 +818,7 @@ module AtsGtpv2C_TestCases { 
            /**

             * @desc    Verify for GTP based on S5/S8 (not PMIP), the Update Bearer Request is sent by the P-GW to the S-GW and then forwarded to the MME 

             * <pre>

             * Pics Selection: PICS_S11_IUT_IS_MME and PICS_MME_UPDATE_BEARER_RESPONSE

             * Pics Selection: PICS_S11_IUT_IS_MME and PICS_MME_DELETE_BEARER_COMMAND

             * Config Id: CF01

             * Initial conditions:

             *  with {
@@ -854,8 +851,8 @@ module AtsGtpv2C_TestCases { 
                // Local variables

                

                // Test control

                if (not (PICS_S11_IUT_IS_MME and PICS_MME_UPDATE_BEARER_RESPONSE)) {

                    log("*** " & testcasename() & ": PICS_S11_IUT_IS_MME and PICS_MME_UPDATE_BEARER_RESPONSE required for executing the TC ***");

                if (not (PICS_S11_IUT_IS_MME and PICS_MME_DELETE_BEARER_COMMAND)) {

                    log("*** " & testcasename() & ": PICS_S11_IUT_IS_MME and PICS_MME_DELETE_BEARER_COMMAND required for executing the TC ***");

                    setverdict(inconc);

                    stop;

                }
@@ -1335,7 +1332,8 @@ module AtsGtpv2C_TestCases { 
        group restorationAndRecovery { 

            

            /**

             * @desc    Procedures during MME/S-GW partial failure

             * @desc    Delete PDN Connection Set Request ProcedureCheck

             *          Procedures during MME/S-GW partial failure

             * <pre>

             * Pics Selection: PICS_S11_IUT_IS_MME and PICS_MME_DELETE_PDN_CONNECTION_SET_REQUEST

             * Config Id: CF01
@@ -1389,7 +1387,8 @@ module AtsGtpv2C_TestCases { 
            } // End of testcase TC_S11_MME_RR_01_01 

            

            /**

             * @desc    Procedures during a Peer’s Partial Failure

             * @desc    Check Delete PDN Connection Set Request Procedure

             *          Procedures during a Peer’s Partial Failure - MME role 

             * <pre>

             * Pics Selection: PICS_S11_IUT_IS_MME and PICS_MME_DELETE_PDN_CONNECTION_SET_REQUEST

             * Config Id: CF02
@@ -1778,7 +1777,7 @@ module AtsGtpv2C_TestCases { 
                

                // Test control

                if (not (PICS_S11_IUT_IS_SGW and PICS_SGW_CREATE_SESSION_RESPONSE and PICS_SGW_CREATE_BEARER_REQUEST and PICS_SGW_MODIFY_BEARER_RESPONSE)) {

                    log("*** " & testcasename() & ": PICS_S11_IUT_IS_SGW and PICS_MME_CREATE_SESSION_REQUEST and PICS_SGW_CREATE_SESSION_RESPONSE and PICS_SGW_CREATE_BEARER_REQUEST and PICS_SGW_MODIFY_BEARER_RESPONSE required for executing the TC ***");

                    log("*** " & testcasename() & ": PICS_S11_IUT_IS_SGW and PICS_SGW_CREATE_SESSION_RESPONSE and PICS_SGW_CREATE_BEARER_REQUEST and PICS_SGW_MODIFY_BEARER_RESPONSE required for executing the TC ***");

                    setverdict(inconc);

                    stop;

                }
@@ -1801,7 +1800,7 @@ module AtsGtpv2C_TestCases { 
             * @desc    Validate that S-GW is able to request the MME to start Create Bearer Request Procedure.

             * <pre>

             * Pics Selection: PICS_S11_IUT_IS_MME and PICS_MME_CREATE_SESSION_REQUEST and PICS_MME_CREATE_BEARER_RESPONSE and PICS_MME_MODIFY_BEARER_REQUEST

             * Config Id: CF01

             * Config Id: CF02

             * Initial conditions:

             *  with {

             *      EPC, RAN, and one UE are available.
@@ -1809,7 +1808,6 @@ module AtsGtpv2C_TestCases { 
             *      S-GW is configured with the GTP Tunnel Parameter.

             *      Verify IP connectivity between the two nodes.

             *      UE attaches to the network. During the attach procedure the S-GW sends the Create Bearer Request message to the MME as part of the Dedicated Bearer Activation Procedure.

             *      The QoS parameter is updated in the P-GW. 

             *  }

             * Expected behaviour:

             *  ensure that {
@@ -1911,7 +1909,7 @@ module AtsGtpv2C_TestCases { 
            } // End of testcase TC_S11_SGW_TM_03 

            

            /**

             * @desc    Validate that a Bearer Resource Command message shall be sent from a MME to a S-GW and forwarded to the PDN-GW as a part of the UE requested bearer resource allocation procedure or UE requested bearer resource modification procedure.

             * @desc    Validate that a Bearer Resource Failure Indication shall be sent by the PDN-GW to an S-GW and forwarded to the MME to indicate failure of the UE requested bearer resource allocation procedure or UE requested bearer resource modification procedure

             * <pre>

             * Pics Selection: PICS_S11_IUT_IS_SGW and PICS_SGW_BEARER_RESOURCE_FAILURE_INDICATION

             * Config Id: CF01
@@ -2082,7 +2080,7 @@ module AtsGtpv2C_TestCases { 
             * @desc    Check that the Serving GW sends a Downlink Data Notification message to the MME for which it has control plane connectivity for a given UE

             * <pre>

             * Pics Selection: PICS_S11_IUT_IS_SGW and PICS_SGW_DOWNLINK_DATA_NOTIFICATION

             * Config Id: CF01

             * Config Id: CF02

             * Initial conditions:

             *  with {

             *      EPC, RAN, and one UE is required.
@@ -2119,16 +2117,17 @@ module AtsGtpv2C_TestCases { 
                }

                

                // Test component configuration

                f_cf01_S11Up_SGW();

                f_cf02_S11Up_SGW();

                

                // Start

				vc_s5.start(f_TC_S5_SGW_TM_07());

                vc_mme.start(f_TC_S11_SGW_TM_07());

                

                // synchronize PTC on 1 sychronization point(s)

                f_serverSyncNClientsAndStop(1, { c_prDone, c_tbDone, c_poDone });

                // synchronize PTC on 2 sychronization point(s)

                f_serverSyncNClientsAndStop(2, { c_prDone, c_tbDone, c_poDone });

                

                // Postamble

                f_cf01_S11Down_SGW();

                f_cf02_S11Down_SGW();

                

            } // End of testcase TC_S11_SGW_TM_07
@@ -2161,7 +2160,7 @@ module AtsGtpv2C_TestCases { 
             * @reference   ETSI TS 129 274, clauses 7.2.11.3

             * @reference   ETSI TS 123.401, clauses 5.3.4.3

             */

            testcase TC_S11_SGW_TM_08() runs on Gtpv2CComponent system Gtpv2CSystemAdapter {

            testcase TC_S11_SGW_TM_08() runs on Gtpv2CComponent system Gtpv2CSystemAdapter { // FIXME This TC seems to be useless

                

                // Local variables
@@ -2346,7 +2345,7 @@ module AtsGtpv2C_TestCases { 
                vc_mme.start(f_TC_S11_SGW_TM_11());

                

                // synchronize PTC on 1 sychronization point(s)

                f_serverSyncNClientsAndStop(1, {c_prDone, c_commandMessagesDone, c_tbDone, c_poDone});

                f_serverSyncNClientsAndStop(1, {c_prDone, c_tbDone, c_poDone});

                

                // Postamble

                f_cf01_S11Down_SGW();
@@ -2356,7 +2355,7 @@ module AtsGtpv2C_TestCases { 
            /**

             * @desc    Verify for GTP based on S5/S8 (not PMIP), the Update Bearer Request is sent by the P-GW to the S-GW and then forwarded to the MME 

             * <pre>

             * Pics Selection: PICS_S11_IUT_IS_SGW and PICS_SGW_UPDATE_BEARER_REQUEST

             * Pics Selection: PICS_S11_IUT_IS_SGW and PICS_SGW_DELETE_BEARER_REQUEST

             * Config Id: CF02

             * Initial conditions:

             *  with {
@@ -2389,8 +2388,8 @@ module AtsGtpv2C_TestCases { 
                // Local variables

                

                // Test control

                if (not (PICS_S11_IUT_IS_SGW and PICS_SGW_UPDATE_BEARER_REQUEST)) {

                    log("*** " & testcasename() & ": PICS_S11_IUT_IS_SGW and PICS_SGW_UPDATE_BEARER_REQUEST required for executing the TC ***");

                if (not (PICS_S11_IUT_IS_SGW and PICS_SGW_DELETE_BEARER_REQUEST)) {

                    log("*** " & testcasename() & ": PICS_S11_IUT_IS_SGW and PICS_SGW_DELETE_BEARER_REQUEST required for executing the TC ***");

                    setverdict(inconc);

                    stop;

                }
@@ -2869,7 +2868,7 @@ module AtsGtpv2C_TestCases { 
        group restorationAndRecovery { 

            

            /**

             * @desc    Procedures during MME/S-GW partial failure

             * @desc    Check Delete PDN Connection Set Request Procedure

             * <pre>

             * Pics Selection: PICS_S11_IUT_IS_SGW and PICS_SGW_DELETE_PDN_CONNECTION_SET_REQUEST

             * Config Id: CF01