- Sep 27, 2017
-
-
Samuel Weiser authored
Reviewed-by:
Paul Dale <paul.dale@oracle.com> Reviewed-by:
Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4377) (cherry picked from commit 9f944291)
-
Samuel Weiser authored
Fixed error in propagating BN_FLG_CONSTTIME flag through BN_MONT_CTX_set, which could lead to information disclosure on RSA primes p and q. Reviewed-by:
-
- Sep 26, 2017
-
-
Richard Levitte authored
Fixes #4419 Reviewed-by:
Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4421)
-
- Sep 19, 2017
-
-
David Benjamin authored
c2i_ASN1_BIT_STRING takes length as a long but uses it as an int. Check bounds before doing so. Previously, excessively large inputs to the function could write a single byte outside the target buffer. (This is unreachable as asn1_ex_c2i already uses int for the length.) Thanks to NCC for finding this issue. Fix written by Martin Kreichgauer. Reviewed-by:
Richard Levitte <levitte@openssl.org> Reviewed-by:
Andy Polyakov <appro@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4385) (cherry picked from commit 6b1c8204)
-
- Sep 11, 2017
-
-
multics authored
Fixes the typo CLA: trivial Reviewed-by:
Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4354) (cherry picked from commit f70c22eb)
-
- Sep 07, 2017
-
-
Rich Salz authored
Reviewed-by:
-
- Aug 28, 2017
-
-
Rich Salz authored
Fixes CVE 2017-3735 Reviewed-by:
Kurt Roeckx <kurt@roeckx.be> (Merged from https://github.com/openssl/openssl/pull/4276) (cherry picked from commit b2317174)
-
- Aug 25, 2017
-
-
Matt Caswell authored
Reviewed-by:
-
- Aug 24, 2017
-
-
Rich Salz authored
Reviewed-by:
-
- Aug 23, 2017
-
-
Dr. Stephen Henson authored
Fix GCM documentation: the tag does not have to be supplied before decrypting any data any more. Reviewed-by:
-
Rich Salz authored
Reviewed-by:
-
- Aug 22, 2017
-
-
Pauli authored
Reviewed-by:
-
- Aug 18, 2017
-
-
Dr. Stephen Henson authored
Fixes #4180 Reviewed-by:
-
David von Oheimb authored
Reviewed-by:
-
Andy Polyakov authored
Reviewed-by:
-
- Aug 17, 2017
-
-
Bernd Edlinger authored
Reviewed-by:
-
- Aug 15, 2017
-
-
Richard Levitte authored
Fixes #3867 Reviewed-by:
-
- Aug 09, 2017
-
-
Xiaoyin Liu authored
In the generated HTML document, the `<pre>` tag is not closed. Reviewed-by:
-
- Aug 07, 2017
-
-
Bernd Edlinger authored
Reviewed-by:
-
Rich Salz authored
Also fix one missing use of it. Thanks to GitHub user Vort for finding it and pointing out the fix. Reviewed-by:
-
- Aug 04, 2017
-
-
Bernd Edlinger authored
Reviewed-by:
-
- Jul 31, 2017
-
-
Bernd Edlinger authored
The memory blocks contain secret data and must be cleared before returning to the system heap. Reviewed-by:
-
- Jul 29, 2017
-
-
Bernd Edlinger authored
and d2i_PKCS8PrivateKey_bio before it goes out of scope. Reviewed-by:
-
- Jul 28, 2017
-
-
Paul Yang authored
Reviewed-by:
-
- Jul 27, 2017
-
-
Paul Yang authored
to address #3973, and original PR to master branch is #3614 test case in the original PR is not applied. Reviewed-by:
-
David Benjamin authored
Reviewed-by:
Ben Kaduk <kaduk@mit.edu> Reviewed-by:
-
- Jul 25, 2017
-
-
Andy Polyakov authored
"Optimize" is in quotes because it's rather a "salvage operation" for now. Idea is to identify processor capability flags that drive Knights Landing to suboptimial code paths and mask them. Two flags were identified, XSAVE and ADCX/ADOX. Former affects choice of AES-NI code path specific for Silvermont (Knights Landing is of Silvermont "ancestry"). And 64-bit ADCX/ADOX instructions are effectively mishandled at decode time. In both cases we are looking at ~2x improvement. Hardware used for benchmarking courtesy of Atos, experiments run by Romain Dolbeau <romain.dolbeau@atos.net>. Kudos! This is minimalistic backpoint of 64d92d74 Thanks to David Benjamin for spotting typo in Knights Landing detection! Reviewed-by:
-
Simon Richter authored
Commit b8326569 fixed whitespace handling in the copy script, which exposes bugs in the install routine for nmake Makefiles. This corrects the quoting around the copy invocation for the openssl.exe binary. CLA: trivial Reviewed-by:
-
- Jul 24, 2017
-
-
Xiaoyin Liu authored
Reviewed-by:
-
Andy Polyakov authored
Reviewed-by:
-
- Jul 22, 2017
-
-
Dr. Stephen Henson authored
Fixes #2718 Reviewed-by:
-
- Jul 20, 2017
-
-
Richard Levitte authored
When an error occurs during the starttls handskake, s_client gets stuck looping around zero bytes reads, because the server won't sent anything more after its error tag. Shutting down on the first zero byte read fixes this. Fixes #3980 Reviewed-by:
-
- Jul 19, 2017
-
-
Matt Caswell authored
The intention of the removed code was to check if the previous operation carried. However this does not work. The "mask" value always ends up being a constant and is all ones - thus it has no effect. This check is no longer required because of the previous commit. Reviewed-by:
-
Matt Caswell authored
In TLS mode of operation the padding value "pad" is obtained along with the maximum possible padding value "maxpad". If pad > maxpad then the data is invalid. However we must continue anyway because this is constant time code. We calculate the payload length like this: inp_len = len - (SHA_DIGEST_LENGTH + pad + 1); However if pad is invalid then inp_len ends up -ve (actually large +ve because it is a size_t). Later we do this: /* verify HMAC */ out += inp_len; len -= inp_len; This ends up with "out" pointing before the buffer which is undefined behaviour. Next we calculate "p" like this: unsigned char *p = out + len - 1 - maxpad - SHA256_DIGEST_LENGTH; Because of the "out + len" term the -ve inp_len value is cancelled out so "p" points to valid memory (although technically the pointer arithmetic is undefined behaviour again). We only ever then dereference "p" and never "out" directly so there is never an invalid read based on the bad pointer - so there is no security issue. This commit fixes the undefined behaviour by ensuring we use maxpad in place of pad, if the supplied pad is invalid. With thanks to Brian Carpenter for reporting this issue. Reviewed-by:
-
- Jul 18, 2017
-
-
Emilia Kasper authored
This is an inherent weakness of the padding mode. We can't make the implementation constant time (see the comments in rsa_pk1.c), so add a warning to the docs. Reviewed-by:
-
- Jul 16, 2017
-
-
Bernd Edlinger authored
Make RSA key exchange code actually constant-time. Reviewed-by:
-
- Jul 15, 2017
-
-
simon-p-r authored
From https://github.com/openssl/openssl/pull/1023 CLA: trivial Reviewed-by:
-
- Jul 06, 2017
-
-
Richard Levitte authored
When tree_calculate_user_set() fails, a jump to error failed to deallocate a possibly allocated |auth_nodes|. Reviewed-by:
-
- Jul 05, 2017
-
-
Bernd Edlinger authored
Fixes #3349 Reviewed-by:
-
Richard Levitte authored
Undoing: > - in UI_process(), |state| was never made NULL, which means an error > when closing the session wouldn't be accurately reported. This was a faulty cherry-pick from master Reviewed-by:
-
