- Dec 04, 2000
-
-
Geoff Thorpe authored
will probably be more when the lh_doall[_arg] callbacks are similarly tidied up, but this 'pod' should now be current.
-
Geoff Thorpe authored
-
Geoff Thorpe authored
cases of function pointer casting in lh_new() calls - and leave only the lh_doall and lh_doall_arg cases to be finished.
-
- Dec 03, 2000
-
-
Ben Laurie authored
-
Bodo Möller authored
-
Bodo Möller authored
might overflow.
-
- Dec 02, 2000
-
-
Geoff Thorpe authored
be used as the hash/compare callbacks without function pointer casting. For now, this is just happening in the apps/ directory whilst a few people check the approach. The rest of the library will be moved across to the same idea if there's no problems with this.
-
Geoff Thorpe authored
IMPLEMENT macros for defining wrapper functions for "hash" and "cmp" callbacks that are specific to the underlying item type in a hash-table. This prevents function pointer casting altogether, and also provides some type-safety because the macro does per-variable casting from the (void *) type used in LHASH itself to the type declared in the macro - and if that doesn't match the prototype expected by the "hash" or "cmp" function then a compiler error will result. NB: IMPLEMENT macros are not required unless predeclared forms are required (either in a header file, or further up in a C file than the implementation needs to be). The DECLARE macros must occur after the type-specific hash/cmp callbacks are declared. Also, the IMPLEMENT and DECLARE macros are such that they can be prefixed with "static" if desired and a trailing semi-colon should be appended (making it look more like a regular declaration and easier on auto-formatting text-editors too). Now that these macros are defined, I will next be commiting changes to a number of places in the library where the casting was doing bad things. After that, the final step will be to make the analogous changes for the lh_doall and lh_doall_arg functions (more specifically, their callback parameters).
-
Richard Levitte authored
-
Ulf Möller authored
-
Ulf Möller authored
-
Ulf Möller authored
-
Ulf Möller authored
-
Ulf Möller authored
if (bp == NULL) for (j=0; j<10000; j++) BN_add(&c,&a,&b); seem to be pretty useless, and bp never is NULL anyway.
-
Ulf Möller authored
-
Ulf Möller authored
The *_part_words functions are not static.
-
Ulf Möller authored
The bn_cmp_part_words bug was only caught in the BN_mod_mul() test, not in the BN_mul() test, so apparently the choice of parameters in some cases is bad.
-
Ulf Möller authored
-
Ulf Möller authored
-
- Dec 01, 2000
-
-
Geoff Thorpe authored
casts) used in the lhash code are about as horrible and evil as they can be. For starters, the callback prototypes contain empty parameter lists. Yuck. This first change defines clearer prototypes - including "typedef"'d function pointer types to use as "hash" and "compare" callbacks, as well as the callbacks passed to the lh_doall and lh_doall_arg iteration functions. Now at least more explicit (and clear) casting is required in all of the dependant code - and that should be included in this commit. The next step will be to hunt down and obliterate some of the function pointer casting being used when it's not necessary - a particularly evil variant exists in the implementation of lh_doall.
-
Richard Levitte authored
a draft.
-
Richard Levitte authored
-
Richard Levitte authored
-
Richard Levitte authored
-
Bodo Möller authored
-
Bodo Möller authored
-
Bodo Möller authored
-
Ulf Möller authored
I hope this adequately summarizes the results of all those disussions.
-
Ulf Möller authored
-
Ulf Möller authored
-
Richard Levitte authored
-
- Nov 30, 2000
-
-
Bodo Möller authored
Don't dump core in ssltest.
-
Bodo Möller authored
-
Richard Levitte authored
First tentative impementation of Kerberos 5 cryptos and keys for SSL/TLS. Implemented by Vern Staats <staatsvr@asc.hpc.mil>, further hacked and distributed by Jeffrey Altman <jaltnab@columbia.edu>
-
Bodo Möller authored
-
Bodo Möller authored
violation in test_kron on a 32 bit system.
-
Bodo Möller authored
But even if this is avoided, there are still segmentation violations (during one of the BN_free()s at the end of test_kron in some cases, in other cases during BN_kronecker, or later in BN_sqrt; choosing a different exponentiation algorithm in bntest.c appears to influence when the SIGSEGV takes place).
-
Bodo Möller authored
-
Richard Levitte authored
-
Bodo Möller authored
Submitted by: Lenka Fibikova
-