Skip to content
  1. May 29, 2014
  2. May 27, 2014
  3. May 26, 2014
  4. May 25, 2014
  5. May 24, 2014
  6. May 23, 2014
  7. May 22, 2014
  8. May 21, 2014
  9. May 20, 2014
  10. May 19, 2014
    • Janpopan's avatar
      Fix a wrong parameter count ERR_add_error_data · ff626ba5
      Janpopan authored
      ff626ba5
    • Ben Laurie's avatar
      Merge branch 'mbland-heartbeat-test' · 814972e1
      Ben Laurie authored
      814972e1
    • Ben Laurie's avatar
      Fixup for ancient compilers. · 2ec52dc3
      Ben Laurie authored
      2ec52dc3
    • Mike Bland's avatar
      Zero-initialize heartbeat test write buffer · 39dd6f45
      Mike Bland authored
      The previous calls to memset() were added to tear_down() when I noticed the
      test spuriously failing in opt mode, with different results each time. This
      appeared to be because the allocator zeros out memory in debug mode, but not
      in opt mode. Since the heartbeat functions silently drop the request on error
      without modifying the contents of the write buffer, whatever random contents
      were in memory before being reallocated to the write buffer used in the test
      would cause nondeterministic test failures in the Heartbleed regression cases.
      Adding these calls allowed the test to pass in both debug and opt modes.
      
      Ben Laurie notified me offline that the test was aborting in
      debug-ben-debug-64-clang mode, configured with GitConfigure and built with
      GitMake. Looking into this, I realized the first memset() call was zeroing out
      a reference count used by SSL_free() that was checked in
      debug-ben-debug-64-clang mode but not in the normal debug mode.
      
      Removing the memset() calls from tear_down() and adding a memset() for the
      write buffer in set_up() addresses the issue and allows the test to
      successfully execute in debug, opt, and debug-ben-debug-64-clang modes.
      39dd6f45
    • Mike Bland's avatar
      More through error checks in set_up · f5ad068b
      Mike Bland authored
      Checks the return values of ssl_init_wbio_buffer() and ssl3_setup_buffers().
      f5ad068b