Commit f32a0a95 authored by Andy Polyakov's avatar Andy Polyakov
Browse files

x509v3/v3_utl.c: avoid double-free. 



Thanks to David Benjamin for spotting this.

Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4532

)

(cherry picked from commit 432f8688)

Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
Reviewed-by: default avatarBernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/4514)
parent a5034bea

crypto/x509v3/v3_utl.c

+3 −1
Original line number Diff line number Diff line
@@ -55,8 +55,10 @@ int X509V3_add_value(const char *name, const char *value, 
    return 1;

 err:

    X509V3err(X509V3_F_X509V3_ADD_VALUE, ERR_R_MALLOC_FAILURE);

    if (sk_allocated)

    if (sk_allocated) {

        sk_CONF_VALUE_free(*extlist);

        *extlist = NULL;

    }

    OPENSSL_free(vtmp);

    OPENSSL_free(tname);

    OPENSSL_free(tvalue);