Commit a5034bea authored by Andy Polyakov's avatar Andy Polyakov
Browse files

crypto/x509v3/v3_utl.c: fix Coverity problems. 



Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4492

)

(cherry picked from commit 32f3b98d)

Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
Reviewed-by: default avatarBernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/4514)
parent 6d2fbe91

crypto/x509v3/v3_utl.c

+4 −1
Original line number Diff line number Diff line
@@ -37,6 +37,7 @@ int X509V3_add_value(const char *name, const char *value, 
{

    CONF_VALUE *vtmp = NULL;

    char *tname = NULL, *tvalue = NULL;

    int sk_allocated = (*extlist == NULL);



    if (name && (tname = OPENSSL_strdup(name)) == NULL)

        goto err;
@@ -44,7 +45,7 @@ int X509V3_add_value(const char *name, const char *value, 
        goto err;

    if ((vtmp = OPENSSL_malloc(sizeof(*vtmp))) == NULL)

        goto err;

    if (*extlist == NULL && (*extlist = sk_CONF_VALUE_new_null()) == NULL)

    if (sk_allocated && (*extlist = sk_CONF_VALUE_new_null()) == NULL)

        goto err;

    vtmp->section = NULL;

    vtmp->name = tname;
@@ -54,6 +55,8 @@ int X509V3_add_value(const char *name, const char *value, 
    return 1;

 err:

    X509V3err(X509V3_F_X509V3_ADD_VALUE, ERR_R_MALLOC_FAILURE);

    if (sk_allocated)

        sk_CONF_VALUE_free(*extlist);

    OPENSSL_free(vtmp);

    OPENSSL_free(tname);

    OPENSSL_free(tvalue);