Commit da27006d authored by Carl Jackson's avatar Carl Jackson Committed by Dr. Stephen Henson
Browse files

Fix regression in ASN1_UTCTIME_cmp_time_t 



Previously, ASN1_UTCTIME_cmp_time_t would return 1 if s > t, -1 if
s < t, and 0 if s == t.

This behavior was broken in a refactor [0], resulting in the opposite
time comparison behavior.

[0]: 904348a4922333106b613754136305db229475ea

PR#3706

Reviewed-by: default avatarStephen Henson <steve@openssl.org>
Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
parent 556efe79

crypto/asn1/a_utctm.c

+1 −1
Original line number Diff line number Diff line
@@ -249,7 +249,7 @@ int ASN1_UTCTIME_cmp_time_t(const ASN1_UTCTIME *s, time_t t) 
    if (!OPENSSL_gmtime(&t, &ttm))

        return -2;



    if (!OPENSSL_gmtime_diff(&day, &sec, &stm, &ttm))

    if (!OPENSSL_gmtime_diff(&day, &sec, &ttm, &stm))

        return -2;



    if (day > 0)