Commit ceffb33d authored by Richard Levitte's avatar Richard Levitte
Browse files

Make sure the temporary error log resides in a well defined location 



If a test recipe does something like this:

    indir "foo.$$" => sub {
        chmod 0500, File::Spec->curdir();
        ok(run(app(["something"])));
    }

we get a problem, because we were storing the temporary stderr file in
the current directory at all times (so while inside the 'indir', we
would attemp to store it in "foo.$$").

So, change our ways to always store that temporary file in the exact
same location, defined by the environment variable RESULT_D, or
failing that TEST_D, or failing that $TOP/test.

Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
parent 2dcac136

test/testlib/OpenSSL/Test.pm

+2 −1
Original line number Diff line number Diff line
@@ -720,7 +720,8 @@ sub __build_cmd { 


    $saved_stderr = $opts{stderr}		if defined($opts{stderr});



    my $errlog = $num ? "$test_name.$num.tmp_err" : "$test_name.tmp_err";

    my $errlog =

        __results_file($num ? "$test_name.$num.tmp_err" : "$test_name.tmp_err");

    my $display_cmd = "$cmd$arg_str$stdin$stdout$stderr";

    $cmd .= "$arg_str$stdin$stdout 2> $errlog";