Commit ad69a303 authored by Matt Caswell's avatar Matt Caswell
Browse files

Fix heartbeat_test 



The heartbeat_test reaches into the internals of libssl and calls some
internal functions. It then checks the return value to check its what it
expected. However commit fa4c3745 changed the return value of these
internal functions, and now the test is failing.

The solution is to update the test to look for the new return value.

Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
parent ba2bf831

ssl/heartbeat_test.c

+4 −4
Original line number Diff line number Diff line
@@ -278,7 +278,7 @@ static int test_dtls1_not_bleeding() 


    fixture.payload = &payload_buf[0];

    fixture.sent_payload_len = payload_buf_len;

    fixture.expected_return_value = 0;

    fixture.expected_return_value = -1;

    fixture.expected_payload_len = payload_buf_len;

    fixture.expected_return_payload =

        "Not bleeding, sixteen spaces of padding";
@@ -301,7 +301,7 @@ static int test_dtls1_not_bleeding_empty_payload() 


    fixture.payload = &payload_buf[0];

    fixture.sent_payload_len = payload_buf_len;

    fixture.expected_return_value = 0;

    fixture.expected_return_value = -1;

    fixture.expected_payload_len = payload_buf_len;

    fixture.expected_return_payload = "";

    EXECUTE_HEARTBEAT_TEST();
@@ -370,7 +370,7 @@ static int test_tls1_not_bleeding() 


    fixture.payload = &payload_buf[0];

    fixture.sent_payload_len = payload_buf_len;

    fixture.expected_return_value = 0;

    fixture.expected_return_value = -1;

    fixture.expected_payload_len = payload_buf_len;

    fixture.expected_return_payload =

        "Not bleeding, sixteen spaces of padding";
@@ -393,7 +393,7 @@ static int test_tls1_not_bleeding_empty_payload() 


    fixture.payload = &payload_buf[0];

    fixture.sent_payload_len = payload_buf_len;

    fixture.expected_return_value = 0;

    fixture.expected_return_value = -1;

    fixture.expected_payload_len = payload_buf_len;

    fixture.expected_return_payload = "";

    EXECUTE_HEARTBEAT_TEST();