Commit a4e584a6 authored by Matt Caswell's avatar Matt Caswell
Browse files

Don't leak resource on error in OCSP_url_svcloc_new 



On error we could leak a ACCESS_DESCRIPTION and an ASN1_IA5STRING. Both
should be freed in the error path.

Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
parent f08e8034

crypto/ocsp/ocsp_ext.c

+4 −0
Original line number Diff line number Diff line
@@ -509,12 +509,16 @@ X509_EXTENSION *OCSP_url_svcloc_new(X509_NAME *issuer, char **urls) 
            goto err;

        ad->location->type = GEN_URI;

        ad->location->d.ia5 = ia5;

        ia5 = NULL;

        if (!sk_ACCESS_DESCRIPTION_push(sloc->locator, ad))

            goto err;

        ad = NULL;

        urls++;

    }

    x = X509V3_EXT_i2d(NID_id_pkix_OCSP_serviceLocator, 0, sloc);

 err:

    ASN1_IA5STRING_free(ia5);

    ACCESS_DESCRIPTION_free(ad);

    OCSP_SERVICELOC_free(sloc);

    return x;

}