Commit 998ae048 authored by Geoff Thorpe's avatar Geoff Thorpe
Browse files

The bn_set_max() macro is only "used" by the bn_set_[low|high]() macros 

which, in turn, are used nowhere at all. This is a good thing because
bn_set_max() would currently generate code that wouldn't compile (BIGNUM
has no 'max' element).

The only apparent use for bn_set_[low|high] would be for implementing
windowing algorithms, and all of openssl's seem to use bn_***_words()
helpers instead (including the BN_div() that Nils fixed recently, which had
been using independently-coded versions of what these unused macros are
intended for). I'm therefore consigning these macros to cvs oblivion in the
name of readability.
parent e65c2b98

crypto/bn/bn_lcl.h

+0 −32
Original line number Diff line number Diff line
@@ -249,38 +249,6 @@ extern "C" { 
		*(++ftl) = 0x0; \

	}





/* This macro is to add extra stuff for development checking */

#ifdef BN_DEBUG

#define	bn_set_max(r) ((r)->max=(r)->top,BN_set_flags((r),BN_FLG_STATIC_DATA))

#else

#define	bn_set_max(r)

#endif



/* These macros are used to 'take' a section of a bignum for read only use */

#define bn_set_low(r,a,n) \

	{ \

	(r)->top=((a)->top > (n))?(n):(a)->top; \

	(r)->d=(a)->d; \

	(r)->neg=(a)->neg; \

	(r)->flags|=BN_FLG_STATIC_DATA; \

	bn_set_max(r); \

	}



#define bn_set_high(r,a,n) \

	{ \

	if ((a)->top > (n)) \

		{ \

		(r)->top=(a)->top-n; \

		(r)->d= &((a)->d[n]); \

		} \

	else \

		(r)->top=0; \

	(r)->neg=(a)->neg; \

	(r)->flags|=BN_FLG_STATIC_DATA; \

	bn_set_max(r); \

	}



#ifdef BN_LLONG

#define mul_add(r,a,w,c) { \

	BN_ULLONG t; \