Commit 72eb100f authored by Richard Levitte's avatar Richard Levitte
Browse files

Don't use '-z defs' with Clang's sanitizers 



The clang documentation in all sanitizers we currently use says this:

    When linking shared libraries, the {flavor}Sanitizer run-time is
    not linked, so -Wl,-z,defs may cause link errors (don’t use it
    with {flavor}Sanitizer)

(in our case, {flavor} is one of Address, Memory, or UndefinedBehavior)

Therefore, we turn off that particular flag specifically when using
the sanitizers.

Fixes #8735

Reviewed-by: default avatarMatt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/8749)
parent f2dbb71c

Configurations/shared-info.pl

+4 −1
Original line number Diff line number Diff line
@@ -32,7 +32,10 @@ my %shared_info; 
        return {

            %{$shared_info{'gnu-shared'}},

            shared_defflag    => '-Wl,--version-script=',

            dso_ldflags       => '-z defs',

            dso_ldflags       =>

                $disabled{asan} && $disabled{msan} && $disabled{ubsan}

                ? '-z defs'

                : '',

        };

    },

    'bsd-gcc-shared' => sub { return $shared_info{'linux-shared'}; },