Commit 4b71f63a authored by Richard Levitte's avatar Richard Levitte
Browse files

Comparing a pointer (data) with 0 using > is incorrect. The changed 

comparison doesn't look right, but at least it compiles.  It would be nice
if the one who knows what this is supposed to do changed it to do it correctly
parent 3adb8c38

crypto/ecdsa/ecs_asn1.c

+3 −1
Original line number Diff line number Diff line
@@ -439,7 +439,9 @@ ECDSA *ECDSA_x9_62parameters2ecdsa(const X9_62_EC_PARAMETERS *params, EC 
		if ((point = EC_POINT_new(ret->group)) == NULL) goto err;

	}

	else OPENSSL_ECDSA_ABORT(ECDSA_R_WRONG_FIELD_IDENTIFIER)

	if (params->curve->seed != NULL && params->curve->seed->data > 0)

	/* FIXME!!!  It seems like the comparison of data with 0 isn't the

	   intended thing. */

	if (params->curve->seed != NULL && params->curve->seed->data != 0)

	{

		if (ret->seed != NULL)

			OPENSSL_free(ret->seed);