Commit 2cfdfe09 authored by Richard Levitte's avatar Richard Levitte
Browse files

Have mkerr.pl treat already existing multiline string defs properly 



Since source reformat, we ended up with some error reason string
definitions that spanned two lines.  That in itself is fine, but we
sometimes edited them to provide better strings than what could be
automatically determined from the reason macro, for example:

    {ERR_REASON(SSL_R_NO_GOST_CERTIFICATE_SENT_BY_PEER),
     "Peer haven't sent GOST certificate, required for selected ciphersuite"},

However, mkerr.pl didn't treat those two-line definitions right, and
they ended up being retranslated to whatever the macro name would
indicate, for example:

    {ERR_REASON(SSL_R_NO_GOST_CERTIFICATE_SENT_BY_PEER),
     "No gost certificate sent by peer"},

Clearly not what we wanted.  This change fixes this problem.

Reviewed-by: default avatarMatt Caswell <matt@openssl.org>
parent be739b0c

util/mkerr.pl

+14 −7
Original line number Diff line number Diff line
@@ -535,15 +535,22 @@ EOF 
	# First, read any existing reason string definitions:

	my %err_reason_strings;

	if (open(IN,"<$cfile")) {

		my $line = "";

		while (<IN>) {

			chomp;

			$_ = $line . $_;

			$line = "";

			if (/{ERR_(FUNC|REASON)\(/) {

				if (/\b(${lib}_R_\w*)\b.*\"(.*)\"/) {

					$err_reason_strings{$1} = $2;

			}

			if (/\b${lib}_F_(\w*)\b.*\"(.*)\"/) {

				} elsif (/\b${lib}_F_(\w*)\b.*\"(.*)\"/) {

					if (!exists $ftrans{$1} && ($1 ne $2)) {

						print STDERR "WARNING: Mismatched function string $2\n";

						$ftrans{$1} = $2;

					}

				} else {

					$line = $_;

				}

			}

		}

		close(IN);