Commit 1c27ce4e authored by Geoff Thorpe's avatar Geoff Thorpe
Browse files

Extend the index parameter checking from sk_value to sk_set(). Also tidy up 

some similar code elsewhere.

Thanks to Francesco Petruzzi for bringing this to my attention.
parent 22083b18

crypto/stack/stack.c

+2 −3
Original line number Diff line number Diff line
@@ -189,8 +189,7 @@ char *sk_delete(STACK *st, int loc) 
	char *ret;

	int i,j;



	if ((st == NULL) || (st->num == 0) || (loc < 0)

					 || (loc >= st->num)) return(NULL);

	if(!st || (loc < 0) || (loc >= st->num)) return NULL;



	ret=st->data[loc];

	if (loc != st->num-1)
@@ -310,7 +309,7 @@ char *sk_value(const STACK *st, int i) 


char *sk_set(STACK *st, int i, char *value)

{

	if(st == NULL) return NULL;

	if(!st || (i < 0) || (i >= st->num)) return NULL;

	return (st->data[i] = value);

}