Commit 0cc092f8 authored by Matt Caswell's avatar Matt Caswell
Browse files

Fix an uninit read picked up by Travis 



The siglen value needs to be initialised prior to it being read in the
call to EVP_DigestSignFinal later in this function.

Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/2157)
parent 1b520cbb

ssl/statem/statem_srvr.c

+2 −2
Original line number Diff line number Diff line
@@ -2240,8 +2240,8 @@ int tls_construct_server_key_exchange(SSL *s, WPACKET *pkt) 
             * up front, and then properly allocate them in the WPACKET

             * afterwards.

             */

            if (!WPACKET_sub_reserve_bytes_u16(pkt, EVP_PKEY_size(pkey),

                                               &sigbytes1)

            siglen = EVP_PKEY_size(pkey);

            if (!WPACKET_sub_reserve_bytes_u16(pkt, siglen, &sigbytes1)

                    || EVP_DigestSignInit(md_ctx, &pctx, md, NULL, pkey) <= 0) {

                SSLerr(SSL_F_TLS_CONSTRUCT_SERVER_KEY_EXCHANGE,

                       ERR_R_INTERNAL_ERROR);