Commit 029e8f3a authored by Matt Caswell's avatar Matt Caswell
Browse files

Don't check for a negative SRP extension size 



The size of the SRP extension can never be negative (the variable
|size| is unsigned). Therefore don't check if it is less than zero.

RT#3862

Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
(cherry picked from commit 9c89d290)
parent 28ea6ad6

ssl/t1_lib.c

+1 −1
Original line number Diff line number Diff line
@@ -1134,7 +1134,7 @@ int ssl_parse_clienthello_tlsext(SSL *s, unsigned char **p, unsigned char *d, 
        }

# ifndef OPENSSL_NO_SRP

        else if (type == TLSEXT_TYPE_srp) {

            if (size <= 0 || ((len = data[0])) != (size - 1)) {

            if (size == 0 || ((len = data[0])) != (size - 1)) {

                *al = SSL_AD_DECODE_ERROR;

                return 0;

            }