- Jul 18, 2014
-
-
Alessandro Ghedini authored
This fixes a build failure on Debian caused by commit 24c3cdce. Bug: http://curl.haxx.se/mail/lib-2014-07/0209.html
-
- Jul 17, 2014
-
-
Steve Holme authored
The curl tool project files for VC8 to VC12 would set this setting to $(IntDir) which is the Visual Studio default value. To avoid confusion when viewing settings from within Visual Studio and for consistency with the libcurl project files removed this setting. Conflicts: projects/Windows/VC10/src/curlsrc.tmpl projects/Windows/VC11/src/curlsrc.tmpl projects/Windows/VC12/src/curlsrc.tmpl projects/Windows/VC8/src/curlsrc.tmpl projects/Windows/VC9/src/curlsrc.tmpl
-
Steve Holme authored
The curl tool project files for VC7 to VC12 would set this settings to $(IntDir)$(TargetName).pch which is the Visual Studio default value. To avoid confusion when viewing settings from within Visual Studio and for consistency with the libcurl project files removed this setting. Conflicts: projects/Windows/VC10/src/curlsrc.tmpl projects/Windows/VC11/src/curlsrc.tmpl projects/Windows/VC12/src/curlsrc.tmpl projects/Windows/VC8/src/curlsrc.tmpl projects/Windows/VC9/src/curlsrc.tmpl
-
Steve Holme authored
The curl tool project files for VC7 to VC12 would set these settings to $(IntDir) which is the Visual Studio default value. To avoid confusion when viewing settings from within Visual Studio and for consistency with the libcurl project files removed these two settings.
-
Dave Reisner authored
This prevents targets like tool_hugehelp.c from leaving around half-constructed files if the rule fails with GNU make. Reported-by: Rafaël Carré <funman@videolan.org>
-
Daniel Stenberg authored
-
- Jul 16, 2014
-
-
Dan Fandrich authored
-
Daniel Stenberg authored
-
Daniel Stenberg authored
-
David Woodhouse authored
-
David Woodhouse authored
It's wrong to assume that we can send a single SPNEGO packet which will complete the authentication. It's a *negotiation* — the clue is in the name. So make sure we handle responses from the server. Curl_input_negotiate() will already handle bailing out if it thinks the state is GSS_S_COMPLETE (or SEC_E_OK on Windows) and the server keeps talking to us, so we should avoid endless loops that way.
-
David Woodhouse authored
GSSAPI doesn't work very well if we forget everything ever time. XX: Is Curl_http_done() the right place to do the final cleanup?
-
David Woodhouse authored
This is the correct way to do SPNEGO. Just ask for it Now I correctly see it trying NTLMSSP authentication when a Kerberos ticket isn't available. Of course, we bail out when the server responds with the challenge packet, since we don't expect that. But I'll fix that bug next...
-
David Woodhouse authored
This is just fundamentally broken. SPNEGO (RFC4178) is a protocol which allows client and server to negotiate the underlying mechanism which will actually be used to authenticate. This is *often* Kerberos, and can also be NTLM and other things. And to complicate matters, there are various different OIDs which can be used to specify the Kerberos mechanism too. A SPNEGO exchange will identify *which* GSSAPI mechanism is being used, and will exchange GSSAPI tokens which are appropriate for that mechanism. But this SPNEGO implementation just strips the incoming SPNEGO packet and extracts the token, if any. And completely discards the information about *which* mechanism is being used. Then we *assume* it was Kerberos, and feed the token into gss_init_sec_context() with the default mechanism (GSS_S_NO_OID for the mech_type argument). Furthermore... broken as this code is, it was never even *used* for input tokens anyway, because higher layers of curl would just bail out if the server actually said anything *back* to us in the negotiation. We assume that we send a single token to the server, and it accepts it. If the server wants to continue the exchange (as is required for NTLM and for SPNEGO to do anything useful), then curl was broken anyway. So the only bit which actually did anything was the bit in Curl_output_negotiate(), which always generates an *initial* SPNEGO token saying "Hey, I support only the Kerberos mechanism and this is its token". You could have done that by manually just prefixing the Kerberos token with the appropriate bytes, if you weren't going to do any proper SPNEGO handling. There's no need for the FBOpenSSL library at all. The sane way to do SPNEGO is just to *ask* the GSSAPI library to do SPNEGO. That's what the 'mech_type' argument to gss_init_sec_context() is for. And then it should all Just Work™. That 'sane way' will be added in a subsequent patch, as will bug fixes for our failure to handle any exchange other than a single outbound token to the server which results in immediate success.
-
David Woodhouse authored
-
David Woodhouse authored
Bumping it to 1KiB in commit aaaf9e50 is all very well, but having hit a hard limit once let's just make it cope by reallocating as necessary.
-
Daniel Stenberg authored
-
- Jul 15, 2014
-
-
Daniel Stenberg authored
After the fixed cookie lock deadlock, this test now passes and it detects double-locking and double-unlocking of mutexes.
-
Yousuke Kimoto authored
... by removing the extra mutex locks around th call to Curl_flush_cookies() which takes care of the locking itself already. Bug: http://curl.haxx.se/mail/lib-2014-02/0184.html
-
Daniel Stenberg authored
conversion to 'int' from 'long int' may alter its value
-
- Jul 14, 2014
-
-
Dan Fandrich authored
It's irrelevant to the test, and will change depending on which SSL library is being used by libcurl.
-
Dan Fandrich authored
Reported-by: David Woodhouse
-
Michał Górny authored
Use ${host_alias}-krb5-config if available. This improves cross- compilation support and fixes multilib on Gentoo (at least).
-
David Woodhouse authored
Before GnuTLS 3.3.6, the gnutls_x509_crt_check_hostname() function didn't actually check IP addresses in SubjectAltName, even though it was explicitly documented as doing so. So do it ourselves...
-
Dan Fandrich authored
-
Daniel Stenberg authored
-
- Jul 12, 2014
-
-
Dan Fandrich authored
Reported-by: David Woodhouse
-
Dan Fandrich authored
The old way using getpwuid could cause problems in programs that enable reading from netrc files simultaneously in multiple threads. Reported-by: David Woodhouse
-
Dan Fandrich authored
-
Dan Fandrich authored
This previously caused a fatal error (with a confusing error code, at that). Reported by: Glen A Johnson Jr.
-
Steve Holme authored
-
Steve Holme authored
Bug: http://curl.haxx.se/mail/lib-2014-07/0103.html Reported-by: David Woodhouse
-
Steve Holme authored
The curl tool project files for VC7 to VC12 would override the default setting with the output filename being the same as the linker PDB file. As such the compiler file would be overwritten with the linker file for all debug builds. To avoid this overwrite and for consistency with the libcurl project files, removed the setting to force the default filename to be used.
-
- Jul 11, 2014
-
-
Dan Fandrich authored
-
Dan Fandrich authored
-
Dan Fandrich authored
-
Dan Fandrich authored
The AES-GCM ciphers were added to GnuTLS as late as ver. 3.0.1 but the code path in which they're referenced here is only ever used for somewhat older GnuTLS versions. This caused undeclared identifier errors when compiling against those.
-
Dan Fandrich authored
This seems to have become necessary for SRP support to work starting with GnuTLS ver. 2.99.0. Since support for SRP was added to GnuTLS before the function that takes this priority string, there should be no issue with backward compatibility.
-
Dan Fandrich authored
-
Dan Fandrich authored
These tests have been broken since commit 1958fe57 in Oct. 2011
-