Skip to content
Snippets Groups Projects
  1. May 24, 2011
    • Yang Tse's avatar
      compiler warning: fix · b7357176
      Yang Tse authored
      Fix compiler warning: variable was set but never used
      
      Fix compiler warning: clobber ignored
      b7357176
  2. Apr 27, 2011
  3. Mar 24, 2010
  4. Oct 27, 2009
  5. Sep 15, 2009
    • Yang Tse's avatar
      Some systems poll function sets POLLHUP in revents without setting · f7690db3
      Yang Tse authored
      POLLIN, and sets POLLERR without setting POLLIN and POLLOUT. In some
      libcurl code execution paths this could trigger busy wait loops with
      high CPU usage until a timeout condition aborted the loop.
      
      This fix for Curl_poll adresses the above in a libcurl-wide mode.
      f7690db3
  6. May 26, 2008
  7. May 09, 2008
  8. Mar 06, 2008
    • Yang Tse's avatar
      Regression fix: · 91aeebed
      Yang Tse authored
      select/poll calls will only be retried upon EINTR failures as
      it previously was in lib/select.c revision 1.29
      
      In this way Curl_socket_ready() and Curl_poll() will again fail
      on any select/poll errors different than EINTR.
      91aeebed
  9. Nov 05, 2007
  10. Oct 03, 2007
  11. May 31, 2007
  12. May 26, 2007
    • Daniel Stenberg's avatar
      Primarily this fixes an off-by-one buffer overwrite (rare but still existing). · 8bd7197a
      Daniel Stenberg authored
      I also switched from calloc() to malloc() as a minor performance boost since
      the rest of the code fills in the structs fine anyway - and they must for the
      case when we use the stack-based auto variable array instead of the allocated
      one.
      
      I made the loop filling in poll_fds[] break when poll_nfds is reached as a
      minor speed improvement.
      8bd7197a
  13. Apr 20, 2007
    • Yang Tse's avatar
      initialize pending_ms to zero to avoid compiler warning: · 7f33aae0
      Yang Tse authored
      'pending_ms' may be used uninitialized in this function
      7f33aae0
    • Yang Tse's avatar
      - Save one call to curlx_tvnow(), which calls gettimeofday(), in each of · 61022f38
      Yang Tse authored
        Curl_socket_ready(), Curl_poll() and Curl_select() when these are called
        with a zero timeout or a timeout value indicating a blocking call should
        be performed.
      
        These unnecessary calls to gettimeofday() got introduced in 7.16.2 when
        fixing 'timeout would restart when signal caught while awaiting socket
        events' on 20 March 2007.
      
      - Move some loop breaking logic from the while clause into the loop,
        avoiding compiler warning 'assignment within conditional expression'
      61022f38
  14. Apr 19, 2007
  15. Apr 16, 2007
  16. Apr 04, 2007
  17. Apr 03, 2007
  18. Apr 02, 2007
  19. Mar 29, 2007
  20. Mar 28, 2007
  21. Mar 27, 2007
  22. Mar 26, 2007
  23. Mar 22, 2007
  24. Mar 21, 2007
  25. Mar 20, 2007
    • Yang Tse's avatar
      Fixed: When a signal was caught awaiting for an event using Curl_select() · e4b754f6
      Yang Tse authored
      or Curl_poll() with a non-zero timeout both functions would restart the
      specified timeout. This could even lead to the extreme case that if a
      signal arrived with a frecuency lower to the specified timeout neither
      function would ever exit.
      
      Added experimental symbol definition check CURL_ACKNOWLEDGE_EINTR in
      Curl_select() and Curl_poll(). When compiled with CURL_ACKNOWLEDGE_EINTR
      defined both functions will return as soon as a signal is caught. Use it
      at your own risk, all calls to these functions in the library should be
      revisited and checked before fully supporting this feature.
      e4b754f6
  26. Mar 18, 2007
  27. Mar 11, 2007
  28. Mar 10, 2007
  29. Feb 26, 2007
  30. Feb 16, 2007
  31. Jan 05, 2007
  32. Jan 02, 2007
    • Daniel Stenberg's avatar
      - Victor Snezhko helped us fix bug report #1603712 · 0682d25d
      Daniel Stenberg authored
        (http://curl.haxx.se/bug/view.cgi?id=1603712) (known bug #36) --limit-rate
        (CURLOPT_MAX_SEND_SPEED_LARGE and CURLOPT_MAX_RECV_SPEED_LARGE) are broken
        on Windows (since 7.16.0, but that's when they were introduced as previous
        to that the limiting logic was made in the application only and not in the
        library). It was actually also broken on select()-based systems (as apposed
        to poll()) but we haven't had any such reports. We now use select(), Sleep()
        or delay() properly to sleep a while without waiting for anything input or
        output when the rate limiting is activated with the easy interface.
      0682d25d
  33. Dec 05, 2006
    • Daniel Stenberg's avatar
      Matt Witherspoon fixed a problem case when the CPU load went to 100% when a · 3ce43764
      Daniel Stenberg authored
      HTTP upload was disconnected:
      
      "What appears to be happening is that my system (Linux 2.6.17 and 2.6.13) is
      setting *only* POLLHUP on poll() when the conditions in my previous mail
      occur. As you can see, select.c:Curl_select() does not check for POLLHUP. So
      basically what was happening, is poll() was returning immediately (with
      POLLHUP set), but when Curl_select() looked at the bits, neither POLLERR or
      POLLOUT was set. This still caused Curl_readwrite() to be called, which
      quickly returned. Then the transfer() loop kept continuing at full speed
      forever."
      3ce43764
  34. Oct 18, 2006
  35. Oct 09, 2006
  36. Sep 24, 2006
Loading