Skip to content
  1. Jun 14, 2018
  2. Jun 13, 2018
  3. Jun 12, 2018
    • Daniel Stenberg's avatar
      runtests: support variables in <strippart> · bb9a340c
      Daniel Stenberg authored
      ... and make use of that to make 1455 work better without using a fixed
      local port number.
      
      Fixes #2649
      Closes #2650
      bb9a340c
    • Daniel Stenberg's avatar
      Curl_debug: remove dead printhost code · 5ae22272
      Daniel Stenberg authored
      The struct field is never set (since 5e0d9aea) so remove the use of it
      and remove the connectdata pointer from the prototype.
      
      Reported-by: Tejas
      Bug: https://curl.haxx.se/mail/lib-2018-06/0054.html
      Closes #2647
      5ae22272
    • Viktor Szakats's avatar
      schannel: avoid incompatible pointer warning · 819f44dc
      Viktor Szakats authored
      with clang-6.0:
      ```
      vtls/schannel_verify.c: In function 'add_certs_to_store':
      vtls/schannel_verify.c:212:30: warning: passing argument 11 of 'CryptQueryObject' from incompatible pointer type [-Wincompatible-pointer-types]
                                    &cert_context)) {
                                    ^
      In file included from /usr/share/mingw-w64/include/schannel.h:10:0,
                       from /usr/share/mingw-w64/include/schnlsp.h:9,
                       from vtls/schannel.h:29,
                       from vtls/schannel_verify.c:40:
      /usr/share/mingw-w64/include/wincrypt.h:4437:26: note: expected 'const void **' but argument is of type 'CERT_CONTEXT ** {aka struct _CERT_CONTEXT **}'
         WINIMPM WINBOOL WINAPI CryptQueryObject (DWORD dwObjectType, const void *pvObject, DWORD dwExpectedContentTypeFlags, DWORD dwExpectedFormatTypeFlags, DWORD dwFlags,
                                ^~~~~~~~~~~~~~~~
      ```
      Ref: https://msdn.microsoft.com/library/windows/desktop/aa380264
      
      Closes https://github.com/curl/curl/pull/2648
      819f44dc
    • Robert Prag's avatar
      schannel: support selecting ciphers · 9aefbff3
      Robert Prag authored
      Given the contstraints of SChannel, I'm exposing these as the algorithms
      themselves instead; while replicating the ciphersuite as specified by
      OpenSSL would have been preferable, I found no way in the SChannel API
      to do so.
      
      To use this from the commandline, you need to pass the names of contants
      defining the desired algorithms. For example, curl --ciphers
      "CALG_SHA1:CALG_RSA_SIGN:CALG_RSA_KEYX:CALG_AES_128:CALG_DH_EPHEM"
      https://github.com The specific names come from wincrypt.h
      
      Closes #2630
      9aefbff3
  4. Jun 11, 2018
  5. Jun 08, 2018
  6. Jun 06, 2018
    • Rikard Falkeborn's avatar
      tests/libtests/Makefile.am: Add lib1521.c to CLEANFILES · b59cbf74
      Rikard Falkeborn authored
      This removes the generated lib1521.c when running make clean.
      
      Closes #2633
      b59cbf74
    • Rikard Falkeborn's avatar
      tests/libtest: Add lib1521 to nodist_SOURCES · 76457ccd
      Rikard Falkeborn authored
      Since 467da3af, lib1521.c is generated instead of checked in. According
      to the commit message, the intention was to remove it from the tarball
      as well. However, it is still present when running make dist. To remove
      it, add it to nodist_lib1521_SOURCES. This also means there is no need
      for the manually added dist-rule in the Makefile.
      
      Also update CMakelists.txt to handle the fact that we now may have
      nodist_SOURCES.
      76457ccd
    • Stephan Mühlstrasser's avatar
      system.h: add support for IBM xlc C compiler · f8045799
      Stephan Mühlstrasser authored
      Added a section to system.h guarded with __xlc__ for the IBM xml C
      compiler. Before this change the section titled 'generic "safe guess" on
      old 32 bit style' was used, which resulted in a wrong definition of
      CURL_TYPEOF_CURL_SOCKLEN_T, and for 64-bit also CURL_TYPEOF_CURL_OFF_T
      was wrong.
      
      Compilation warnings fixed with this change:
      
        CC       libcurl_la-ftp.lo
      "ftp.c", line 290.55: 1506-280 (W) Function argument assignment between types "unsigned long* restrict" and "int*" is not allowed.
      "ftp.c", line 293.48: 1506-280 (W) Function argument assignment between types "unsigned long* restrict" and "int*" is not allowed.
      "ftp.c", line 1070.49: 1506-280 (W) Function argument assignment between types "unsigned long* restrict" and "int*" is not allowed.
      "ftp.c", line 1154.53: 1506-280 (W) Function argument assignment between types "unsigned long* restrict" and "int*" is not allowed.
      "ftp.c", line 1187.51: 1506-280 (W) Function argument assignment between types "unsigned long* restrict" and "int*" is not allowed.
        CC       libcurl_la-connect.lo
      "connect.c", line 448.56: 1506-280 (W) Function argument assignment between types "unsigned long* restrict" and "int*" is not allowed.
      "connect.c", line 516.66: 1506-280 (W) Function argument assignment between types "unsigned long* restrict" and "int*" is not allowed.
      "connect.c", line 687.55: 1506-280 (W) Function argument assignment between types "unsigned long* restrict" and "int*" is not allowed.
      "connect.c", line 696.55: 1506-280 (W) Function argument assignment between types "unsigned long* restrict" and "int*" is not allowed.
        CC       libcurl_la-tftp.lo
      "tftp.c", line 1115.33: 1506-280 (W) Function argument assignment between types "unsigned long* restrict" and "int*" is not allowed.
      
      Closes #2637
      f8045799
  7. Jun 05, 2018
  8. Jun 03, 2018
    • Viktor Szakats's avatar
      spelling fixes · 4bd91bc4
      Viktor Szakats authored
      Detected using the `codespell` tool (version 1.13.0).
      
      Also secure and fix an URL.
      4bd91bc4
  9. Jun 02, 2018
  10. Jun 01, 2018
  11. May 31, 2018
  12. May 30, 2018
    • Viktor Szakats's avatar
      curl.rc: embed manifest for correct Windows version detection · ebd21327
      Viktor Szakats authored
      * enable it in `src/Makefile.m32`
      * enable it in `winbuild/MakefileBuild.vc` if a custom manifest is
        _not_ enabled via the existing `EMBED_MANIFEST` option
      * enable it for all Windows CMake builds (also disable the built-in
        minimal manifest, added by CMake by default.)
      
      For other build systems, add the `-DCURL_EMBED_MANIFEST` option to
      the list of RC (Resource Compiler) flags to enable the manifest
      included in `src/curl.rc`. This may require to disable whatever
      automatic or other means in which way another manifest is added to
      `curl.exe`.
      
      Notice that Borland C doesn't support this method due to a
      long-pending resource compiler bug. Watcom C may also not handle
      it correctly when the `-zm` `wrc` option is used (this option may
      be unnecessary though) and regardless of options in certain earlier
      revisions of the 2.0 beta version.
      
      Closes https://github.com/curl/curl/pull/1221
      Fixes https://github.com/curl/curl/issues/2591
      ebd21327