Commit f67009dd authored by Cliff Crosland's avatar Cliff Crosland Committed by Jay Satiro
Browse files

url: Fix CURLOPT_MAXAGE_CONN time comparison 

Old connections are meant to expire from the connection cache after
CURLOPT_MAXAGE_CONN seconds. However, they actually expire after 1000x
that value. This occurs because a time value measured in milliseconds is
accidentally divided by 1M instead of by 1,000.

Closes https://github.com/curl/curl/pull/4013
parent 29177f42

lib/url.c

+1 −1
Original line number Diff line number Diff line
@@ -975,7 +975,7 @@ static bool conn_maxage(struct Curl_easy *data, 
    timediff_t idletime = Curl_timediff(now, conn->lastused);

    idletime /= 1000; /* integer seconds is fine */



    if(idletime/1000 > data->set.maxage_conn) {

    if(idletime > data->set.maxage_conn) {

      infof(data, "Too old connection (%ld seconds), disconnect it\n",

            idletime);

      return TRUE;