Unverified Commit f260b9e9 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

urlapi: reduce variable scope, remove unreachable 'break' 

Both nits pointed out by codacy.com

Closes #3540
parent b3cc8017

lib/urlapi.c

+10 −10
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ 
 *                            | (__| |_| |  _ <| |___

 *                             \___|\___/|_| \_\_____|

 *

 * Copyright (C) 1998 - 2018, Daniel Stenberg, <daniel@haxx.se>, et al.

 * Copyright (C) 1998 - 2019, Daniel Stenberg, <daniel@haxx.se>, et al.

 *

 * This software is licensed as described in the file COPYING, which

 * you should have received as part of this distribution. The terms
@@ -574,7 +574,8 @@ UNITTEST CURLUcode Curl_parse_port(struct Curl_URL *u, char *hostname) 
/* scan for byte values < 31 or 127 */

static CURLUcode junkscan(char *part)

{

  char badbytes[]={

  if(part) {

    static const char badbytes[]={

      /* */ 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,

      0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f,

      0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17,
@@ -582,7 +583,6 @@ static CURLUcode junkscan(char *part) 
      0x7f,

      0x00 /* zero terminate */

    };

  if(part) {

    size_t n = strlen(part);

    size_t nfine = strcspn(part, badbytes);

    if(nfine != n)
@@ -1083,10 +1083,10 @@ CURLUcode curl_url_get(CURLU *u, CURLUPart what, 
      return CURLUE_OUT_OF_MEMORY;

    *part = url;

    return CURLUE_OK;

    break;

  }

  default:

    ptr = NULL;

    break;

  }

  if(ptr) {

    *part = strdup(ptr);