Commit e9a46041 authored by Dan Fandrich's avatar Dan Fandrich
Browse files

Fixed an infinite loop when given an invalid SFTP quote command.

parent a57098ea

CHANGES

+1 −1
Original line number Diff line number Diff line
@@ -8,7 +8,7 @@ 


Daniel Fandrich (18 Mar 2008)

- Added test 626 to reproduce an infinite loop when given an invalid

  SFTP quote command reported by Vincent Le Normand, but left it disabled.

  SFTP quote command reported by Vincent Le Normand, and fixed it.



Michal Marek (18 Mar 2008)

- Added curl_easy_getinfo typechecker.

RELEASE-NOTES

+1 −0
Original line number Diff line number Diff line
@@ -46,6 +46,7 @@ This release includes the following bugfixes: 
 o sharing DNS cache between easy handles running in multiple threads could

   lead to crash

 o SFTP upload with CURLOPT_FTP_CREATE_MISSING_DIRS on re-used connection

 o SFTP infinite loop when given an invalid quote command



This release includes the following known bugs:

lib/ssh.c

+8 −8
Original line number Diff line number Diff line
@@ -956,14 +956,14 @@ static CURLcode ssh_statemach_act(struct connectdata *conn) 
        break;

      }



      if(sshc->quote_path1) {

      failf(data, "Unknown SFTP command");

      Curl_safefree(sshc->quote_path1);

      sshc->quote_path1 = NULL;

      }

      if(sshc->quote_path2) {

      Curl_safefree(sshc->quote_path2);

      sshc->quote_path2 = NULL;

      }

      state(conn, SSH_SFTP_CLOSE);

      sshc->actualcode = CURLE_QUOTE_ERROR;

      break;

    }

  }

  if(!sshc->quote_item) {

tests/data/DISABLED

+0 −1
Original line number Diff line number Diff line
@@ -4,4 +4,3 @@ 
# per line.

# Lines starting with '#' letters are treated as comments.

617
 
626

tests/data/test626

+3 −3
Original line number Diff line number Diff line
@@ -32,9 +32,9 @@ Test file for rename test 
#

# Verify data after the test has been "shot"

<verify>

<file name="log/file626-renamed.txt">

Test file for rename test

</file>

<errorcode>

21

</errorcode>

<valgrind>

disable

</valgrind>