Commit e2c6e005 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

- Based on bug report #2723219 (http://curl.haxx.se/bug/view.cgi?id=2723219)

  I've now made TFTP "connections" not being kept for re-use within libcurl.
  TFTP is UDP-based so the benefit was really low (if even existing) to begin
  with so instead of tracking down to fix this problem we instead removed the
  re-use. I also enabled test case 1099 that I wrote a few days ago to verify
  that this change fixes the reported problem.
parent e4a0001f
Loading
Loading
Loading
Loading
+8 −0
Original line number Diff line number Diff line
@@ -6,6 +6,14 @@

                                  Changelog

Daniel Stenberg (29 Apr 2009)
- Based on bug report #2723219 (http://curl.haxx.se/bug/view.cgi?id=2723219)
  I've now made TFTP "connections" not being kept for re-use within libcurl.
  TFTP is UDP-based so the benefit was really low (if even existing) to begin
  with so instead of tracking down to fix this problem we instead removed the
  re-use. I also enabled test case 1099 that I wrote a few days ago to verify
  that this change fixes the reported problem.

Daniel Stenberg (28 Apr 2009)
- Constantine Sapuntzakis filed bug report #2783090
  (http://curl.haxx.se/bug/view.cgi?id=2783090) pointing out that on windows
+1 −0
Original line number Diff line number Diff line
@@ -35,6 +35,7 @@ This release includes the following bugfixes:
 o crash related to FTP and "Re-used connection seems dead, get a new one"
 o CURLINFO_APPCONNECT_TIME with the multi interface
 o Enhanced upload speeds on Windows
 o TFTP problems after a failed transfer to the same host

This release includes the following known bugs:

+0 −2
Original line number Diff line number Diff line
@@ -3,8 +3,6 @@ To be addressed in 7.19.5 (planned release: May 2009)

221 - debian man page warnings

222 - TFTP close bug/fix, #2723219

223 - TFTP flaw, #2723236

226 - Active Mode FTPS Data Port Range
+3 −1
Original line number Diff line number Diff line
@@ -863,7 +863,9 @@ static CURLcode tftp_connect(struct connectdata *conn, bool *done)
      return CURLE_OUT_OF_MEMORY;
  }

  conn->bits.close = FALSE; /* keep it open if possible */
  conn->bits.close = TRUE; /* we don't keep TFTP connections up bascially
                              because there's none or very little gain for UDP
                           */

  state->conn = conn;
  state->sockfd = state->conn->sock[FIRSTSOCKET];
+1 −1
Original line number Diff line number Diff line
@@ -3,4 +3,4 @@
# test cases are run by runtests.pl. Just add the plain test case numbers, one
# per line.
# Lines starting with '#' letters are treated as comments.
1099
Loading