Unverified Commit d5c03510 authored by Marcel Raad's avatar Marcel Raad
Browse files

configure: conditionally enable pedantic-errors 

Enable pedantic-errors for GCC >= 5 with --enable-werror. Before GCC 5,
pedantic-errors was synonymous to -Werror=pedantic [0], which is still
the case for clang [1]. With GCC 5, it became complementary [2].

Also fix a resulting error in acinclude.m4 as main's return type was
missing, which is illegal in C99.

[0] https://gcc.gnu.org/onlinedocs/gcc-4.9.0/gcc/Warning-Options.html
[1] https://clang.llvm.org/docs/UsersManual.html#options-to-control-error-and-warning-messages
[2] https://gcc.gnu.org/onlinedocs/gcc-5.1.0/gcc/Warning-Options.html

Closes https://github.com/curl/curl/pull/2747
parent a829c4b2

acinclude.m4

+1 −1
Original line number Diff line number Diff line
@@ -2158,7 +2158,7 @@ AC_DEFUN([CURL_VERIFY_RUNTIMELIBS], [ 
    dnl point also is available run-time!

    AC_MSG_CHECKING([run-time libs availability])

    CURL_RUN_IFELSE([

main()

int main()

{

  return 0;

}

configure.ac

+7 −0
Original line number Diff line number Diff line
@@ -61,6 +61,13 @@ AC_SUBST(CONFIGURE_OPTIONS) 
CURL_CFLAG_EXTRAS=""

if test X"$want_werror" = Xyes; then

  CURL_CFLAG_EXTRAS="-Werror"

  if test "$compiler_id" = "GNU_C"; then

    dnl enable -pedantic-errors for GCC 5 and later,

    dnl as before that it was the same as -Werror=pedantic

    if test "$compiler_num" -ge "500"; then

      CURL_CFLAG_EXTRAS="$CURL_CFLAG_EXTRAS -pedantic-errors"

    fi

  fi

fi

AC_SUBST(CURL_CFLAG_EXTRAS)